From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: Hugh Dickins <hughd@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
jfs-discussion@lists.sourceforge.net,
Kernel Testers List <kernel-testers@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Maciej Rutecki <maciej.rutecki@gmail.com>,
Florian Mickler <florian@mickler.org>,
davem@davemloft.net, Al Viro <viro@zeniv.linux.org.uk>,
linux-mm@kvack.org
Subject: Re: [PATCH v2] vfs: __read_cache_page should use gfp argument rather than GFP_KERNEL
Date: Wed, 21 Dec 2011 12:28:43 -0800 [thread overview]
Message-ID: <20111221122843.18f673c7.akpm@linux-foundation.org> (raw)
In-Reply-To: <4EF211EC.7090002@oracle.com>
On Wed, 21 Dec 2011 11:05:48 -0600
Dave Kleikamp <dave.kleikamp@oracle.com> wrote:
> [ updated to remove now-obsolete comment in read_cache_page_gfp()]
>
> lockdep reports a deadlock in jfs because a special inode's rw semaphore
> is taken recursively. The mapping's gfp mask is GFP_NOFS, but is not used
> when __read_cache_page() calls add_to_page_cache_lru().
Well hang on, it's not just a lockdep splat. The kernel actually will
deadlock if we reenter JFS via this GFP_KERNEL allocation attempt, yes?
Was that GFP_NOFS allocation recently added to JFS? If not then we
should backport this deadlock fix into -stable, no?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-21 20:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201112210054.46995.rjw@sisk.pl>
[not found] ` <CA+55aFzee7ORKzjZ-_PrVy796k2ASyTe_Odz=ji7f1VzToOkKw@mail.gmail.com>
[not found] ` <4EF15F42.4070104@oracle.com>
2011-12-21 4:44 ` [Resend] 3.2-rc6+: Reported regressions from 3.0 and 3.1 Linus Torvalds
2011-12-21 6:15 ` Hugh Dickins
2011-12-21 7:10 ` Al Viro
2011-12-21 17:05 ` [PATCH v2] vfs: __read_cache_page should use gfp argument rather than GFP_KERNEL Dave Kleikamp
2011-12-21 20:28 ` Andrew Morton [this message]
2011-12-21 20:53 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221122843.18f673c7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dave.kleikamp@oracle.com \
--cc=davem@davemloft.net \
--cc=florian@mickler.org \
--cc=hughd@google.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maciej.rutecki@gmail.com \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).