From: Mel Gorman <mgorman@suse.de>
To: Hillf Danton <dhillf@gmail.com>
Cc: linux-mm@kvack.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: vmscan: fix setting reclaim mode
Date: Tue, 10 Jan 2012 16:44:07 +0000 [thread overview]
Message-ID: <20120110164407.GD4118@suse.de> (raw)
In-Reply-To: <CAJd=RBA7vj83SFQFMS5WaRCfz2ndGJXepBqi5tK0LPjnBYYgfg@mail.gmail.com>
On Tue, Jan 10, 2012 at 11:58:03PM +0800, Hillf Danton wrote:
> From: Hillf Danton <dhillf@gmail.com>
> [PATCH] mm: vmscan: fix setting reclaim mode
>
> The comment says, initially assume we are entering either lumpy reclaim or
> reclaim/compaction, and depending on the reclaim order, we will either set the
> sync mode or just reclaim order-0 pages later.
>
> On other hand, order-0 reclaim, instead of sync reclaim, is expected when
> under memory pressure, but the check for memory pressure is incorrect,
> leading to sync reclaim at low reclaim priorities.
>
> And the result is sync reclaim is set for high priorities.
>
RECLAIM_MODE_SYNC is only set for RECLAIM_MODE_LUMPYRECLAIM. Even when
using RECLAIM_MODE_LUMPYRECLAIM, it should only be set when reclaim
is under memory pressure and failing to reclaim the necessry pages
(priority < DEF_PRIORITY - 2). Once in symc reclaim, reclaim will call
wait_on_page_writeback() on dirty pages which potentially leads to
significant stalls (one of the reasons why RECLAIM_MODE_LUMPYRECLAIM
sucks and why compaction is preferred). Your patch means sync reclaim
is used even when priority == DEF_PRIORITY. This is unexpected.
Your changelog really needs to explain what the problem is that you
have encountered and why this patch fixes it. It's not like some of
your other patches which were minor performance optimisations that
were self-evident.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-10 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-08 7:05 [PATCH] mm: vmscan: fix setting reclaim mode Hillf Danton
2012-01-10 9:44 ` Mel Gorman
2012-01-10 15:58 ` Hillf Danton
2012-01-10 16:44 ` Mel Gorman [this message]
2012-01-10 16:58 ` Hillf Danton
2012-01-11 12:12 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110164407.GD4118@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).