* [PATCH] mm: vmscan: no change of reclaim mode if unevictable page encountered
@ 2012-01-07 3:46 Hillf Danton
2012-01-10 9:40 ` Mel Gorman
0 siblings, 1 reply; 5+ messages in thread
From: Hillf Danton @ 2012-01-07 3:46 UTC (permalink / raw)
To: linux-mm
Cc: KAMEZAWA Hiroyuki, David Rientjes, Mel Gorman, Andrew Morton,
Hillf Danton, LKML
Since unevictable page is not isolated from lru list for shrink_page_list(),
it is accident if encountered in shrinking, and no need to change reclaim mode.
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Hillf Danton <dhillf@gmail.com>
---
--- a/mm/vmscan.c Thu Dec 29 20:20:16 2011
+++ b/mm/vmscan.c Sat Jan 7 11:27:44 2012
@@ -995,7 +995,6 @@ cull_mlocked:
try_to_free_swap(page);
unlock_page(page);
putback_lru_page(page);
- reset_reclaim_mode(sc);
continue;
activate_locked:
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: vmscan: no change of reclaim mode if unevictable page encountered
2012-01-07 3:46 [PATCH] mm: vmscan: no change of reclaim mode if unevictable page encountered Hillf Danton
@ 2012-01-10 9:40 ` Mel Gorman
2012-01-10 16:27 ` Hillf Danton
0 siblings, 1 reply; 5+ messages in thread
From: Mel Gorman @ 2012-01-10 9:40 UTC (permalink / raw)
To: Hillf Danton
Cc: linux-mm, KAMEZAWA Hiroyuki, David Rientjes, Andrew Morton, LKML
On Sat, Jan 07, 2012 at 11:46:17AM +0800, Hillf Danton wrote:
> Since unevictable page is not isolated from lru list for shrink_page_list(),
> it is accident if encountered in shrinking, and no need to change reclaim mode.
>
This changelog does does not explain the problem, does not explain
what is fixed or what the impact is.
It also does not make sense. It says "unevictable page is not isolated
from LRU list" but this is shrink_page_list() and the page has already
been isolated (probably by lumpy reclaim). It will be put back on
the LRU_UNEVICTABLE list.
It might be the case that resetting the reclaim mode after encountering
mlocked pages is overkill but that would need more justification than
what this changelog offers. Resetting the mode impacts THP rates but
this is erring on the side of caution by doing less work in reclaim
as the savings from THP may not offset the cost of reclaim.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: vmscan: no change of reclaim mode if unevictable page encountered
2012-01-10 9:40 ` Mel Gorman
@ 2012-01-10 16:27 ` Hillf Danton
2012-01-10 16:57 ` Mel Gorman
0 siblings, 1 reply; 5+ messages in thread
From: Hillf Danton @ 2012-01-10 16:27 UTC (permalink / raw)
To: Mel Gorman
Cc: linux-mm, KAMEZAWA Hiroyuki, David Rientjes, Andrew Morton, LKML
On Tue, Jan 10, 2012 at 5:40 PM, Mel Gorman <mgorman@suse.de> wrote:
> On Sat, Jan 07, 2012 at 11:46:17AM +0800, Hillf Danton wrote:
>> Since unevictable page is not isolated from lru list for shrink_page_list(),
>> it is accident if encountered in shrinking, and no need to change reclaim mode.
>>
>
> This changelog does does not explain the problem, does not explain
> what is fixed or what the impact is.
>
> It also does not make sense. It says "unevictable page is not isolated
> from LRU list" but this is shrink_page_list() and the page has already
> been isolated (probably by lumpy reclaim). It will be put back on
> the LRU_UNEVICTABLE list.
>
> It might be the case that resetting the reclaim mode after encountering
> mlocked pages is overkill but that would need more justification than
> what this changelog offers. Resetting the mode impacts THP rates but
> this is erring on the side of caution by doing less work in reclaim
> as the savings from THP may not offset the cost of reclaim.
>
Hi Mel
It is reprepared, please review again.
Thanks
Hillf
===cut please===
From: Hillf Danton <dhillf@gmail.com>
[PATCH] mm: vmscan: no change of reclaim mode if unevictable page encountered
Unevictable pages are not isolated from lru list for shrink_page_list(), and
they could be put back onto lru list if accidentally encountered in shrinking.
But resetting reclaim mode maybe overkill, as it impacts THP rates. This is
erring on the side of caution by doing less work in reclaim as the savings
from THP may not offset the cost of reclaim.
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Hillf Danton <dhillf@gmail.com>
---
--- a/mm/vmscan.c Thu Dec 29 20:20:16 2011
+++ b/mm/vmscan.c Sat Jan 7 11:27:44 2012
@@ -995,7 +995,6 @@ cull_mlocked:
try_to_free_swap(page);
unlock_page(page);
putback_lru_page(page);
- reset_reclaim_mode(sc);
continue;
activate_locked:
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: vmscan: no change of reclaim mode if unevictable page encountered
2012-01-10 16:27 ` Hillf Danton
@ 2012-01-10 16:57 ` Mel Gorman
2012-01-11 12:14 ` Hillf Danton
0 siblings, 1 reply; 5+ messages in thread
From: Mel Gorman @ 2012-01-10 16:57 UTC (permalink / raw)
To: Hillf Danton
Cc: linux-mm, KAMEZAWA Hiroyuki, David Rientjes, Andrew Morton, LKML
On Wed, Jan 11, 2012 at 12:27:53AM +0800, Hillf Danton wrote:
> On Tue, Jan 10, 2012 at 5:40 PM, Mel Gorman <mgorman@suse.de> wrote:
> > On Sat, Jan 07, 2012 at 11:46:17AM +0800, Hillf Danton wrote:
> >> Since unevictable page is not isolated from lru list for shrink_page_list(),
> >> it is accident if encountered in shrinking, and no need to change reclaim mode.
> >>
> >
> > This changelog does does not explain the problem, does not explain
> > what is fixed or what the impact is.
> >
> > It also does not make sense. It says "unevictable page is not isolated
> > from LRU list" but this is shrink_page_list() and the page has already
> > been isolated (probably by lumpy reclaim). It will be put back on
> > the LRU_UNEVICTABLE list.
> >
> > It might be the case that resetting the reclaim mode after encountering
> > mlocked pages is overkill but that would need more justification than
> > what this changelog offers. Resetting the mode impacts THP rates but
> > this is erring on the side of caution by doing less work in reclaim
> > as the savings from THP may not offset the cost of reclaim.
> >
>
> Hi Mel
>
> It is reprepared, please review again.
>
> Thanks
> Hillf
>
> ===cut please===
> From: Hillf Danton <dhillf@gmail.com>
> [PATCH] mm: vmscan: no change of reclaim mode if unevictable page encountered
>
> Unevictable pages are not isolated from lru list for shrink_page_list(), and
> they could be put back onto lru list if accidentally encountered in shrinking.
>
> But resetting reclaim mode maybe overkill, as it impacts THP rates. This is
> erring on the side of caution by doing less work in reclaim as the savings
> from THP may not offset the cost of reclaim.
>
When I said it needed more justification, I meant that you need to show
a workload or usecase that suffers as a result of reset_reclaim_mode
being called here. I explained already that the reset errs on the
side of caution by making reclaim work less.
You need to describe what problem your workload is suffering from and
why this patch fixes it.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm: vmscan: no change of reclaim mode if unevictable page encountered
2012-01-10 16:57 ` Mel Gorman
@ 2012-01-11 12:14 ` Hillf Danton
0 siblings, 0 replies; 5+ messages in thread
From: Hillf Danton @ 2012-01-11 12:14 UTC (permalink / raw)
To: Mel Gorman
Cc: linux-mm, KAMEZAWA Hiroyuki, David Rientjes, Andrew Morton, LKML
On Wed, Jan 11, 2012 at 12:57 AM, Mel Gorman <mgorman@suse.de> wrote:
>
> When I said it needed more justification, I meant that you need to show
> a workload or usecase that suffers as a result of reset_reclaim_mode
> being called here. I explained already that the reset errs on the
> side of caution by making reclaim work less.
>
> You need to describe what problem your workload is suffering from and
> why this patch fixes it.
>
Got and thanks for review /Hillf
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-01-11 12:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-07 3:46 [PATCH] mm: vmscan: no change of reclaim mode if unevictable page encountered Hillf Danton
2012-01-10 9:40 ` Mel Gorman
2012-01-10 16:27 ` Hillf Danton
2012-01-10 16:57 ` Mel Gorman
2012-01-11 12:14 ` Hillf Danton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).