From: Andrew Morton <akpm@linux-foundation.org>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Nitin Gupta <ngupta@vflare.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Brian King <brking@linux.vnet.ibm.com>,
Konrad Wilk <konrad.wilk@oracle.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
linux-mm@kvack.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] staging: zsmalloc: zsmalloc memory allocation library
Date: Fri, 20 Jan 2012 14:12:32 -0800 [thread overview]
Message-ID: <20120120141232.a7572919.akpm@linux-foundation.org> (raw)
In-Reply-To: <1326149520-31720-2-git-send-email-sjenning@linux.vnet.ibm.com>
On Mon, 9 Jan 2012 16:51:56 -0600
Seth Jennings <sjenning@linux.vnet.ibm.com> wrote:
> This patch creates a new memory allocation library named
> zsmalloc.
I haven't really begun to look at this yet. The code is using many
fields of struct page in new ways. This is key information for anyone
to effectively review the code. So please carefully document (within
the code itself) the ways in which the various page fields are used:
semantic meaning of the overload, relationships between them, any
locking rules or assumptions. Ditto any other data structures. This
code should be reviewed very carefully by others so please implement it
with that intention.
It appears that a pile of dead code will be generated if CPU hotplug is
disabled. (That's if it compiles at all!). Please take a look at users
of hotcpu_notifier() - this facility cunningly causes all the hotplug code
to vanish from vmlinux if it is unneeded.
afacit this code should be added to core mm/. Addition of code like
this to core mm/ will be fiercely resisted on principle! Hence the
(currently missing) justifications for adding it had best be good ones.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-20 22:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 22:51 [PATCH 0/5] staging: zsmalloc: memory allocator for compressed pages Seth Jennings
2012-01-09 22:51 ` [PATCH 1/5] staging: zsmalloc: zsmalloc memory allocation library Seth Jennings
2012-01-20 22:12 ` Andrew Morton [this message]
2012-01-23 14:36 ` Seth Jennings
2012-01-23 18:57 ` Nitin Gupta
2012-01-23 19:40 ` Andrew Morton
2012-01-26 19:12 ` Dave Hansen
2012-02-06 17:26 ` Seth Jennings
2012-02-08 16:39 ` Dave Hansen
2012-02-08 17:15 ` Dan Magenheimer
2012-02-08 17:21 ` Dave Hansen
2012-02-08 17:53 ` Nitin Gupta
2012-02-08 18:28 ` Dave Hansen
2012-02-08 20:57 ` Nitin Gupta
2012-02-08 21:39 ` Dan Magenheimer
2012-02-08 23:07 ` Dave Hansen
2012-01-09 22:51 ` [PATCH 2/5] staging: add zsmalloc to Kconfig/Makefile Seth Jennings
2012-01-09 22:51 ` [PATCH 3/5] staging: zcache: replace xvmalloc with zsmalloc Seth Jennings
2012-02-09 1:13 ` Greg KH
2012-02-09 14:36 ` Seth Jennings
2012-02-09 14:55 ` Seth Jennings
2012-02-09 18:13 ` Greg KH
2012-02-09 18:28 ` Seth Jennings
2012-01-09 22:51 ` [PATCH 4/5] staging: zram: " Seth Jennings
2012-01-09 22:52 ` [PATCH 5/5] staging: zram: remove xvmalloc Seth Jennings
2012-01-09 23:09 ` [PATCH 0/5] staging: zsmalloc: memory allocator for compressed pages Greg KH
2012-01-09 23:26 ` Seth Jennings
2012-01-20 22:03 ` Andrew Morton
2012-01-23 14:27 ` Seth Jennings
[not found] <<1326149520-31720-1-git-send-email-sjenning@linux.vnet.ibm.com>
[not found] ` <<1326149520-31720-2-git-send-email-sjenning@linux.vnet.ibm.com>
2012-01-11 17:19 ` [PATCH 1/5] staging: zsmalloc: zsmalloc memory allocation library Dan Magenheimer
2012-01-11 17:45 ` Seth Jennings
2012-01-11 21:44 ` Dan Magenheimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120120141232.a7572919.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=brking@linux.vnet.ibm.com \
--cc=dan.magenheimer@oracle.com \
--cc=dave@linux.vnet.ibm.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).