From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx203.postini.com [74.125.245.203]) by kanga.kvack.org (Postfix) with SMTP id 1AC176B004F for ; Fri, 27 Jan 2012 07:45:34 -0500 (EST) Date: Fri, 27 Jan 2012 10:44:06 -0200 From: Rafael Aquini Subject: Re: [resubmit] Re: [PATCH] tracing: adjust shrink_slab beginning trace event name Message-ID: <20120127124405.GA2092@x61.redhat.com> References: <20111223141619.GA19720@x61.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111223141619.GA19720@x61.redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Johannes Weiner , Minchan Kim , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Rik van Riel , Mel Gorman , Andrew Morton , Ingo Molnar , Frederic Weisbecker , Steven Rostedt While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern: _begin _end However, the 'beginning' tracing event for shrink_slab() did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency. Signed-off-by: Rafael Aquini Reviewed-by: Minchan Kim Acked-by: KOSAKI Motohiro --- include/trace/events/vmscan.h | 2 +- mm/vmscan.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h index f64560e..595a6f0 100644 --- a/include/trace/events/vmscan.h +++ b/include/trace/events/vmscan.h @@ -179,7 +179,7 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_softlimit_re TP_ARGS(nr_reclaimed) ); -TRACE_EVENT(mm_shrink_slab_start, +TRACE_EVENT(mm_shrink_slab_begin, TP_PROTO(struct shrinker *shr, struct shrink_control *sc, long nr_objects_to_shrink, unsigned long pgs_scanned, unsigned long lru_pgs, unsigned long cache_items, diff --git a/mm/vmscan.c b/mm/vmscan.c index c52b235..84f4fd2 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -325,7 +325,7 @@ unsigned long shrink_slab(struct shrink_control *shrink, if (total_scan > max_pass * 2) total_scan = max_pass * 2; - trace_mm_shrink_slab_start(shrinker, shrink, nr, + trace_mm_shrink_slab_begin(shrinker, shrink, nr, nr_pages_scanned, lru_pages, max_pass, delta, total_scan); -- 1.7.7.6 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org