From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx196.postini.com [74.125.245.196]) by kanga.kvack.org (Postfix) with SMTP id 718276B004D for ; Mon, 30 Jan 2012 05:26:53 -0500 (EST) Date: Mon, 30 Jan 2012 10:26:42 +0000 From: Mel Gorman Subject: Re: [PATCH v3 -mm 1/3] mm: reclaim at order 0 when compaction is enabled Message-ID: <20120130102642.GA25268@csn.ul.ie> References: <20120126145450.2d3d2f4c@cuia.bos.redhat.com> <20120126145914.58619765@cuia.bos.redhat.com> <4F22D236.4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <4F22D236.4@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: Hillf Danton , linux-mm@kvack.org, lkml , Andrea Arcangeli , Johannes Weiner , Andrew Morton , Minchan Kim On Fri, Jan 27, 2012 at 11:35:02AM -0500, Rik van Riel wrote: > On 01/27/2012 04:13 AM, Hillf Danton wrote: > > >>@@ -1195,7 +1195,7 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan, > >> BUG(); > >> } > >> > >>- if (!order) > >>+ if (!sc->order || !(sc->reclaim_mode& RECLAIM_MODE_LUMPYRECLAIM)) > >> continue; > >> > >Just a tiny advice 8-) > > > >mind to move checking lumpy reclaim out of the loop, > >something like > > Hehe, I made the change the way it is on request > of Mel Gorman :) > Yes. I recognise that checking inside the loop like this results in a tiny hit but it is hardly critical. By putting the check here, it is absolutely clear that this is now a lumpy-reclaim only thing where it used to be used by both lumpy reclaim and reclaim/compaction. It'll make deleting lumpy reclaim a little bit easier in the future. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org