From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx134.postini.com [74.125.245.134]) by kanga.kvack.org (Postfix) with SMTP id 71B0F6B13F0 for ; Fri, 3 Feb 2012 08:48:32 -0500 (EST) Date: Fri, 3 Feb 2012 21:38:23 +0800 From: Wu Fengguang Subject: Re: [PATCH 2/2] mm: make do_writepages() use plugging Message-ID: <20120203133823.GB17571@localhost> References: <1328275626-5322-1-git-send-email-amit.sahrawat83@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1328275626-5322-1-git-send-email-amit.sahrawat83@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Amit Sahrawat Cc: Jan Kara , Andrew Morton , Peter Zijlstra , Johannes Weiner , Amit Sahrawat , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Fri, Feb 03, 2012 at 06:57:06PM +0530, Amit Sahrawat wrote: > This will cover all the invocations for writepages to be called with > plugging support. Thanks. I'll test it on the major filesystems. But would you name a few filesystems that are expected to benefit from it? It's not obvious because some FS ->writepages eventually calls generic_writepages() which already does plugging. Thanks, Fengguang > Signed-off-by: Amit Sahrawat > --- > mm/page-writeback.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 363ba70..2bea32c 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -1866,14 +1866,18 @@ EXPORT_SYMBOL(generic_writepages); > > int do_writepages(struct address_space *mapping, struct writeback_control *wbc) > { > + struct blk_plug plug; > int ret; > > if (wbc->nr_to_write <= 0) > return 0; > + > + blk_start_plug(&plug); > if (mapping->a_ops->writepages) > ret = mapping->a_ops->writepages(mapping, wbc); > else > ret = generic_writepages(mapping, wbc); > + blk_finish_plug(&plug); > return ret; > } > > -- > 1.7.2.3 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org