From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx168.postini.com [74.125.245.168]) by kanga.kvack.org (Postfix) with SMTP id 5A8A46B13F0 for ; Thu, 9 Feb 2012 19:27:43 -0500 (EST) Date: Thu, 9 Feb 2012 16:27:41 -0800 From: Andrew Morton Subject: Re: [PATCH 6/6] pagemap: introduce data structure for pagemap entry Message-Id: <20120209162741.283ecb76.akpm@linux-foundation.org> In-Reply-To: <1328716302-16871-7-git-send-email-n-horiguchi@ah.jp.nec.com> References: <1328716302-16871-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1328716302-16871-7-git-send-email-n-horiguchi@ah.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Naoya Horiguchi Cc: linux-mm@kvack.org, David Rientjes , Andi Kleen , Wu Fengguang , Andrea Arcangeli , KOSAKI Motohiro , KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org On Wed, 8 Feb 2012 10:51:42 -0500 Naoya Horiguchi wrote: > Currently a local variable of pagemap entry in pagemap_pte_range() > is named pfn and typed with u64, but it's not correct (pfn should > be unsigned long.) > This patch introduces special type for pagemap entry and replace > code with it. > > Signed-off-by: Naoya Horiguchi > Cc: Andrew Morton > > Changes since v4: > - Rename pme_t to pagemap_entry_t hm. Why this change? I'd have thought that this should be called pme_t. And defined in or under pgtable.h, rather than being private to fs/proc/task_mmu.c. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org