From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx121.postini.com [74.125.245.121]) by kanga.kvack.org (Postfix) with SMTP id 7C3A66B00F3 for ; Mon, 20 Feb 2012 17:33:16 -0500 (EST) Date: Mon, 20 Feb 2012 23:33:13 +0100 From: Jan Kara Subject: Re: [PATCH 01/11] perf: Push file_update_time() into perf_mmap_fault() Message-ID: <20120220223313.GD32708@quack.suse.cz> References: <1329399979-3647-1-git-send-email-jack@suse.cz> <1329399979-3647-2-git-send-email-jack@suse.cz> <1329400247.2293.219.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1329400247.2293.219.camel@twins> Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra Cc: Jan Kara , LKML , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Eric Sandeen , Dave Chinner , Ingo Molnar , Paul Mackerras , Arnaldo Carvalho de Melo On Thu 16-02-12 14:50:47, Peter Zijlstra wrote: > On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote: > > CC: Peter Zijlstra > > CC: Ingo Molnar > > CC: Paul Mackerras > > CC: Arnaldo Carvalho de Melo > > Signed-off-by: Jan Kara > > --- > > kernel/events/core.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/kernel/events/core.c b/kernel/events/core.c > > index ba36013..61a67f3 100644 > > --- a/kernel/events/core.c > > +++ b/kernel/events/core.c > > @@ -3316,8 +3316,10 @@ static int perf_mmap_fault(struct vm_area_struct *vma, struct vm_fault *vmf) > > int ret = VM_FAULT_SIGBUS; > > > > if (vmf->flags & FAULT_FLAG_MKWRITE) { > > - if (vmf->pgoff == 0) > > + if (vmf->pgoff == 0) { > > ret = 0; > > + file_update_time(vma->vm_file); > > + } > > return ret; > > } > > Its an anon filedesc, there's no actual file and while I guess one could > probably call fstat() on it, people really shouldn't care. > > So feel free to introduce this patch to the bitbucket. Thanks for letting me know. Patch removed. Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org