From: Andrew Morton <akpm@linux-foundation.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, mgorman@suse.de,
kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com,
viro@zeniv.linux.org.uk, hughd@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hugetlbfs: Add new rw_semaphore to fix truncate/read race
Date: Mon, 27 Feb 2012 15:11:35 -0800 [thread overview]
Message-ID: <20120227151135.7d4076c6.akpm@linux-foundation.org> (raw)
In-Reply-To: <1330280398-27956-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On Sun, 26 Feb 2012 23:49:58 +0530
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>
> Drop using inode->i_mutex from read, since that can result in deadlock with
> mmap. Ideally we can extend the patch to make sure we don't increase i_size
> in mmap. But that will break userspace, because application will have to now
> use truncate(2) to increase i_size in hugetlbfs.
>
> AFAIU i_mutex was added in hugetlbfs_read as per
> http://lkml.indiana.edu/hypermail/linux/kernel/0707.2/3066.html
This patch comes somewhat out of the blue and I'm unsure what's going on.
You say there's some (potential?) deadlock with mmap, but it is
undescribed. Have people observed this deadlock? Has it caused
lockdep warnings? Please update the changelog to fully describe the
bug.
Also, the new truncate_sem is undoumented. This leaves readers to work
out for themselves what it might be for. Please let's add code
comments which completely describe the race, and how this lock prevents
it.
We should also document our locking rules. When should code take this
lock? What are its ranking rules with respect to i_mutex, i_mmap_mutex
and possibly others?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-02-27 23:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 18:19 [PATCH] hugetlbfs: Add new rw_semaphore to fix truncate/read race Aneesh Kumar K.V
2012-02-27 23:11 ` Andrew Morton [this message]
2012-02-28 0:02 ` Al Viro
2012-02-28 10:15 ` Aneesh Kumar K.V
2012-02-28 12:17 ` Hillf Danton
2012-02-29 11:04 ` Aneesh Kumar K.V
2012-02-29 14:42 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227151135.7d4076c6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).