From: Rafael Aquini <aquini@redhat.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, Randy Dunlap <rdunlap@xenotime.net>,
Christoph Lameter <cl@linux-foundation.org>,
Matt Mackall <mpm@selenic.com>, Rik van Riel <riel@redhat.com>,
Josef Bacik <josef@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] oom: add sysctl to enable slab memory dump
Date: Wed, 29 Feb 2012 00:39:09 -0300 [thread overview]
Message-ID: <20120229033908.GA28416@t510.redhat.com> (raw)
In-Reply-To: <CAOJsxLExoyzvpRNOEdT3+x1mhSCZt0dO7NLKkpi7CrJ7HW2kpw@mail.gmail.com>
On Fri, Feb 24, 2012 at 12:05:27PM +0200, Pekka Enberg wrote:
> On Fri, Feb 24, 2012 at 12:03 PM, David Rientjes <rientjes@google.com> wrote:
> > I like how slub handles this when it can't allocate more slab with
> > slab_out_of_memory() and has the added benefit of still warning even with
> > __GFP_NORETRY that the oom killer is never called for. If there's really
> > a slab leak happening, there's a good chance that this diagnostic
> > information is going to be emitted by the offending cache at some point in
> > time if you're using slub. This could easily be extended to slab.c, so
> > it's even more reason not to include this type of information in the oom
> > killer.
>
> Works for me. Rafael?
New patch, following the suggested approach, posted:
https://lkml.org/lkml/2012/2/28/561
Thanks folks, for all your feedback here!
Rafael
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-02-29 3:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 11:53 [PATCH] oom: add sysctl to enable slab memory dump Rafael Aquini
2012-02-22 13:17 ` Pekka Enberg
2012-02-22 16:04 ` Rafael Aquini
2012-02-22 13:55 ` Christoph Lameter
2012-02-22 16:14 ` Rafael Aquini
2012-02-22 16:29 ` Christoph Lameter
2012-02-23 0:44 ` David Rientjes
2012-02-23 15:02 ` Josef Bacik
2012-02-23 23:09 ` David Rientjes
2012-02-24 15:10 ` Josef Bacik
2012-02-24 21:45 ` David Rientjes
2012-02-24 21:52 ` Pekka Enberg
2012-02-24 23:51 ` David Rientjes
2012-02-23 15:22 ` Rafael Aquini
2012-02-23 16:03 ` Pekka Enberg
2012-02-23 23:17 ` David Rientjes
2012-02-24 6:57 ` Pekka Enberg
2012-02-24 10:03 ` David Rientjes
2012-02-24 10:05 ` Pekka Enberg
2012-02-24 10:38 ` Rafael Aquini
2012-02-29 3:39 ` Rafael Aquini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229033908.GA28416@t510.redhat.com \
--to=aquini@redhat.com \
--cc=cl@linux-foundation.org \
--cc=josef@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rdunlap@xenotime.net \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).