From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx202.postini.com [74.125.245.202]) by kanga.kvack.org (Postfix) with SMTP id 6BB8D6B002C for ; Thu, 1 Mar 2012 07:42:03 -0500 (EST) Date: Thu, 1 Mar 2012 20:36:40 +0800 From: Fengguang Wu Subject: Re: [PATCH 5/9] writeback: introduce the pageout work Message-ID: <20120301123640.GA30369@localhost> References: <20120228140022.614718843@intel.com> <20120228144747.198713792@intel.com> <20120228160403.9c9fa4dc.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120228160403.9c9fa4dc.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Greg Thelen , Jan Kara , Ying Han , "hannes@cmpxchg.org" , KAMEZAWA Hiroyuki , Rik van Riel , Mel Gorman , Minchan Kim , Linux Memory Management List , LKML > Please have a think about all of this and see if you can demonstrate > how the iput() here is guaranteed safe. There are already several __iget()/iput() calls inside fs-writeback.c. The existing iput() calls already demonstrate its safety? Basically the flusher works in this way - the dirty inode list i_wb_list does not reference count the inode at all - the flusher thread does something analog to igrab() and set I_SYNC before going off to writeout the inode - evice() will wait for completion of I_SYNC Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org