From: Mel Gorman <mgorman@suse.de>
To: David Rientjes <rientjes@google.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
Miao Xie <miaox@cn.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuset: mm: Remove memory barrier damage from the page allocator
Date: Mon, 5 Mar 2012 09:44:11 +0000 [thread overview]
Message-ID: <20120305094411.GD3481@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1203021540040.18377@chino.kir.corp.google.com>
On Fri, Mar 02, 2012 at 03:47:17PM -0800, David Rientjes wrote:
> On Fri, 2 Mar 2012, Peter Zijlstra wrote:
>
> > Also, for the write side it doesn't really matter, changing mems_allowed
> > should be rare and is an 'expensive' operation anyway.
> >
>
> It's very expensive even without memory barriers since the page allocator
> wraps itself in {get,put}_mems_allowed() until a page or NULL is returned
> and an update to current's set of allowed mems can stall indefinitely
> trying to change the nodemask during this time.
Hmm, this sounds problematic. Are you seeing a problem with the behaviour
with the patch applied or the existing behaviour?
If you are talking about the patch, I am missing something. The retry
only takes place if there is a parallel update of the nodemask and the
page allocation fails. There would need to be continual updates of the
nodemask that led to false allocation failures for it to stall indefinitely.
On the updating of the cpumask side, there is no longer the "yield and retry"
logic so it also should not stall indefinitely trying to change the nodemask.
The write_seqcount_begin() does not wait for the reader side to complete
so it should also not be stalling for long periods of time.
Did I miss something?
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-05 9:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 11:23 [PATCH] cpuset: mm: Remove memory barrier damage from the page allocator Mel Gorman
2012-03-02 16:19 ` Christoph Lameter
2012-03-02 17:43 ` Mel Gorman
2012-03-02 19:53 ` Christoph Lameter
2012-03-02 21:25 ` Peter Zijlstra
2012-03-02 23:47 ` David Rientjes
2012-03-05 9:44 ` Mel Gorman [this message]
2012-03-06 23:31 ` David Rientjes
2012-03-05 9:35 ` Mel Gorman
2012-03-02 21:21 ` Peter Zijlstra
2012-03-05 20:18 ` Andrew Morton
2012-03-06 2:01 ` [RFC PATCH] checkpatch: Warn on use of yield() Joe Perches
2012-03-06 12:45 ` Peter Zijlstra
2012-03-06 13:14 ` Glauber Costa
2012-03-06 13:25 ` Peter Zijlstra
2012-03-06 13:27 ` Glauber Costa
2012-03-06 17:41 ` Joe Perches
2012-03-06 17:54 ` Peter Zijlstra
2012-03-06 18:00 ` Joe Perches
2012-03-06 18:17 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305094411.GD3481@suse.de \
--to=mgorman@suse.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miaox@cn.fujitsu.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).