From: Rafael Aquini <aquini@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Rik van Riel <riel@redhat.com>, Josef Bacik <josef@redhat.com>
Subject: Re: [PATCH -v2] mm: SLAB Out-of-memory diagnostics
Date: Wed, 7 Mar 2012 11:18:37 -0300 [thread overview]
Message-ID: <20120307141836.GA2009@x61.redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203061941210.24600@chino.kir.corp.google.com>
Howdy David,
On Tue, Mar 06, 2012 at 07:41:55PM -0800, David Rientjes wrote:
> > + spin_lock_irqsave(&l3->list_lock, flags);
>
> Could be spin_lock_irq(&l3->list_lock);
I don't think it would be safe making such assumption.
Note that spin_lock_irqsave() is used at slab_out_of_memory() because we cannot
guarantee that interrupts will be enabled/disabled by the time kmem_getpages()
is called in cache_grow() or fallback_alloc().
Rafael
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-07 14:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 18:10 [PATCH -v2] mm: SLAB Out-of-memory diagnostics Rafael Aquini
2012-03-05 20:02 ` Rik van Riel
2012-03-07 3:41 ` David Rientjes
2012-03-07 14:18 ` Rafael Aquini [this message]
2012-03-07 5:06 ` Cong Wang
2012-03-07 5:42 ` David Rientjes
2012-03-07 14:46 ` Rafael Aquini
2012-03-09 19:41 ` Pekka Enberg
2012-03-09 20:27 ` [PATCH v3] " Rafael Aquini
2012-03-09 20:33 ` Pekka Enberg
2012-03-09 23:46 ` David Rientjes
2012-03-10 8:48 ` Pekka Enberg
2012-03-10 0:23 ` Eric Dumazet
2012-03-10 3:16 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120307141836.GA2009@x61.redhat.com \
--to=aquini@redhat.com \
--cc=cl@linux-foundation.org \
--cc=josef@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rdunlap@xenotime.net \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).