From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx161.postini.com [74.125.245.161]) by kanga.kvack.org (Postfix) with SMTP id BDE646B002C for ; Wed, 7 Mar 2012 21:07:16 -0500 (EST) Date: Wed, 7 Mar 2012 18:09:17 -0800 From: Andrew Morton Subject: Re: [patch 1/2] mm, counters: remove task argument to sync_mm_rss and __sync_task_rss_stat Message-Id: <20120307180917.7d570d95.akpm@linux-foundation.org> In-Reply-To: References: <20120307171155.f9bb71b6.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: KAMEZAWA Hiroyuki , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Wed, 7 Mar 2012 17:40:04 -0800 (PST) David Rientjes wrote: > On Wed, 7 Mar 2012, Andrew Morton wrote: > > > hm, with my gcc it's beneficial to cache `current' in a local. But > > when I tried that, Weird Things happened, because gcc has gone and > > decided to inline __sync_task_rss_stat() into its callers. I don't see > > how that could have been the right thing to do. > > > > c06b1fca18c3 offers some advice :) But is it right? I handled a patch a month or two ago where caching current made a nice improvement. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org