From: Andrew Morton <akpm@linux-foundation.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: David Rientjes <rientjes@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
Balbir Singh <bsingharora@gmail.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, memcg: do not allow tasks to be attached with zero limit
Date: Thu, 8 Mar 2012 17:38:18 -0800 [thread overview]
Message-ID: <20120308173818.ae5f621b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120309102255.bbf94164.kamezawa.hiroyu@jp.fujitsu.com>
On Fri, 9 Mar 2012 10:22:55 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Thu, 8 Mar 2012 12:29:51 -0800
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Wed, 7 Mar 2012 19:14:49 -0800 (PST)
> > David Rientjes <rientjes@google.com> wrote:
> >
> > > This patch prevents tasks from being attached to a memcg if there is a
> > > hard limit of zero.
> >
> > We're talking about the memcg's limit_in_bytes here, yes?
> >
> > > Additionally, the hard limit may not be changed to
> > > zero if there are tasks attached.
> >
> > hm, well... why? That would be user error, wouldn't it? What is
> > special about limit_in_bytes=0? The memcg will also be unviable if
> > limit_in_bytes=1, but we permit that.
> >
> > IOW, confused.
> >
> Ah, yes. limit_in_bytes < some small size can cause the same trouble.
> Hmm... should we have configurable min_limit_in_bytes as sysctl or root memcg's
> attaribute.. ?
Why do *anything*? If the operator chose an irrational configuration
then things won't work correctly and the operator will then fix the
configuration?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-09 1:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 3:14 [patch] mm, memcg: do not allow tasks to be attached with zero limit David Rientjes
2012-03-08 6:15 ` KAMEZAWA Hiroyuki
2012-03-08 20:29 ` Andrew Morton
2012-03-09 1:22 ` KAMEZAWA Hiroyuki
2012-03-09 1:38 ` Andrew Morton [this message]
2012-03-09 1:57 ` KAMEZAWA Hiroyuki
2012-03-13 16:51 ` Johannes Weiner
2012-03-14 9:42 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308173818.ae5f621b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).