linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	Hugh Dickins <hughd@google.com>,
	Johannes Weiner <jweiner@redhat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH v5 7/7] mm/memcg: use vm_swappiness from target memory cgroup
Date: Thu, 08 Mar 2012 22:04:30 +0400	[thread overview]
Message-ID: <20120308180430.27621.99232.stgit@zurg> (raw)
In-Reply-To: <20120308175752.27621.54781.stgit@zurg>

Use vm_swappiness from memory cgroup which is triggered this memory reclaim.
This is more reasonable and allows to kill one argument.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>

---

add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-2 (-2)
function                                     old     new   delta
shrink_mem_cgroup_zone                      1583    1581      -2
---
 mm/vmscan.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 9a41769..95719f3 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1859,12 +1859,11 @@ static unsigned long shrink_list(enum lru_list lru, unsigned long nr_to_scan,
 	return shrink_inactive_list(nr_to_scan, mz, sc, priority, lru);
 }
 
-static int vmscan_swappiness(struct mem_cgroup_zone *mz,
-			     struct scan_control *sc)
+static int vmscan_swappiness(struct scan_control *sc)
 {
 	if (global_reclaim(sc))
 		return vm_swappiness;
-	return mem_cgroup_swappiness(mz->mem_cgroup);
+	return mem_cgroup_swappiness(sc->target_mem_cgroup);
 }
 
 /*
@@ -1933,8 +1932,8 @@ static void get_scan_count(struct mem_cgroup_zone *mz, struct scan_control *sc,
 	 * With swappiness at 100, anonymous and file have the same priority.
 	 * This scanning priority is essentially the inverse of IO cost.
 	 */
-	anon_prio = vmscan_swappiness(mz, sc);
-	file_prio = 200 - vmscan_swappiness(mz, sc);
+	anon_prio = vmscan_swappiness(sc);
+	file_prio = 200 - vmscan_swappiness(sc);
 
 	/*
 	 * OK, so we have swap space and a fair amount of page cache

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2012-03-08 18:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 18:03 [PATCH v5 0/7] mm: some cleanup/rework before lru_lock splitting Konstantin Khlebnikov
2012-03-08 18:04 ` [PATCH v5 1/7] mm/memcg: scanning_global_lru means mem_cgroup_disabled Konstantin Khlebnikov
2012-03-09  1:26   ` KAMEZAWA Hiroyuki
2012-03-08 18:04 ` [PATCH v5 2/7] mm/memcg: move reclaim_stat into lruvec Konstantin Khlebnikov
2012-03-09  1:27   ` KAMEZAWA Hiroyuki
2012-03-08 18:04 ` [PATCH v5 3/7] mm: push lru index into shrink_[in]active_list() Konstantin Khlebnikov
2012-03-09  1:28   ` KAMEZAWA Hiroyuki
2012-03-08 18:04 ` [PATCH v5 4/7] mm: rework __isolate_lru_page() page lru filter Konstantin Khlebnikov
2012-03-09  1:30   ` KAMEZAWA Hiroyuki
2012-03-08 18:04 ` [PATCH v5 5/7] mm: rework reclaim_stat counters Konstantin Khlebnikov
2012-03-09  1:32   ` KAMEZAWA Hiroyuki
2012-03-08 18:04 ` [PATCH v5 6/7] mm/memcg: rework inactive_ratio calculation Konstantin Khlebnikov
2012-03-08 18:04 ` Konstantin Khlebnikov [this message]
2012-03-09  1:33   ` [PATCH v5 7/7] mm/memcg: use vm_swappiness from target memory cgroup KAMEZAWA Hiroyuki
2012-03-11 14:36 ` [PATCH v5 4.5/7] mm: optimize isolate_lru_pages() Konstantin Khlebnikov
2012-03-13  5:26   ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120308180430.27621.99232.stgit@zurg \
    --to=khlebnikov@openvz.org \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=jweiner@redhat.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).