From: Rafael Aquini <aquini@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Rik van Riel <riel@redhat.com>, Josef Bacik <josef@redhat.com>,
David Rientjes <rientjes@google.com>,
Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH v3] mm: SLAB Out-of-memory diagnostics
Date: Sat, 10 Mar 2012 00:16:48 -0300 [thread overview]
Message-ID: <20120310031647.GA2988@t510.redhat.com> (raw)
In-Reply-To: <1331339019.4063.365.camel@edumazet-glaptop>
Howdy Eric,
On Fri, Mar 09, 2012 at 04:23:39PM -0800, Eric Dumazet wrote:
> On Fri, 2012-03-09 at 17:27 -0300, Rafael Aquini wrote:
> > Following the example at mm/slub.c, add out-of-memory diagnostics to the
> > SLAB allocator to help on debugging certain OOM conditions.
> >
> > An example print out looks like this:
> >
> > <snip page allocator out-of-memory message>
> > SLAB: Unable to allocate memory on node 0 (gfp=0x11200)
> > cache: bio-0, object size: 192, order: 0
> > node 0: slabs: 3/3, objs: 60/60, free: 0
>
> Should probably be :
>
> node: 0 slabs: 3/3, objs: 60/60, free: 0
>
No it shouldn't. Please refer to https://lkml.org/lkml/2012/3/7/242
The intent here was just to match slub's printout for its slab_out_of_memory
node list slab components, as one can check on mm/slub.c:
2096 printk(KERN_WARNING
2097 " node %d: slabs: %ld, objs: %ld, free: %ld\n",
2098 node, nr_slabs, nr_objs, nr_free);
> > + printk(KERN_WARNING
> > + " node %d: slabs: %ld/%ld, objs: %ld/%ld, free: %ld\n",
>
> Probably should be :
> " node: %d slabs: %ld/%ld, objs: %ld/%ld, free: %ld\n",
>
ditto.
Thanks for your feedback!
Rafael
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-03-10 3:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 18:10 [PATCH -v2] mm: SLAB Out-of-memory diagnostics Rafael Aquini
2012-03-05 20:02 ` Rik van Riel
2012-03-07 3:41 ` David Rientjes
2012-03-07 14:18 ` Rafael Aquini
2012-03-07 5:06 ` Cong Wang
2012-03-07 5:42 ` David Rientjes
2012-03-07 14:46 ` Rafael Aquini
2012-03-09 19:41 ` Pekka Enberg
2012-03-09 20:27 ` [PATCH v3] " Rafael Aquini
2012-03-09 20:33 ` Pekka Enberg
2012-03-09 23:46 ` David Rientjes
2012-03-10 8:48 ` Pekka Enberg
2012-03-10 0:23 ` Eric Dumazet
2012-03-10 3:16 ` Rafael Aquini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120310031647.GA2988@t510.redhat.com \
--to=aquini@redhat.com \
--cc=cl@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=josef@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rdunlap@xenotime.net \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).