From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx110.postini.com [74.125.245.110]) by kanga.kvack.org (Postfix) with SMTP id 953676B0044 for ; Fri, 9 Mar 2012 22:19:48 -0500 (EST) Date: Sat, 10 Mar 2012 00:16:48 -0300 From: Rafael Aquini Subject: Re: [PATCH v3] mm: SLAB Out-of-memory diagnostics Message-ID: <20120310031647.GA2988@t510.redhat.com> References: <20120309202722.GA10323@x61.redhat.com> <1331339019.4063.365.camel@edumazet-glaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331339019.4063.365.camel@edumazet-glaptop> Sender: owner-linux-mm@kvack.org List-ID: To: Eric Dumazet Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Randy Dunlap , Christoph Lameter , Pekka Enberg , Matt Mackall , Rik van Riel , Josef Bacik , David Rientjes , Cong Wang Howdy Eric, On Fri, Mar 09, 2012 at 04:23:39PM -0800, Eric Dumazet wrote: > On Fri, 2012-03-09 at 17:27 -0300, Rafael Aquini wrote: > > Following the example at mm/slub.c, add out-of-memory diagnostics to the > > SLAB allocator to help on debugging certain OOM conditions. > > > > An example print out looks like this: > > > > > > SLAB: Unable to allocate memory on node 0 (gfp=0x11200) > > cache: bio-0, object size: 192, order: 0 > > node 0: slabs: 3/3, objs: 60/60, free: 0 > > Should probably be : > > node: 0 slabs: 3/3, objs: 60/60, free: 0 > No it shouldn't. Please refer to https://lkml.org/lkml/2012/3/7/242 The intent here was just to match slub's printout for its slab_out_of_memory node list slab components, as one can check on mm/slub.c: 2096 printk(KERN_WARNING 2097 " node %d: slabs: %ld, objs: %ld, free: %ld\n", 2098 node, nr_slabs, nr_objs, nr_free); > > + printk(KERN_WARNING > > + " node %d: slabs: %ld/%ld, objs: %ld/%ld, free: %ld\n", > > Probably should be : > " node: %d slabs: %ld/%ld, objs: %ld/%ld, free: %ld\n", > ditto. Thanks for your feedback! Rafael -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org