From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx165.postini.com [74.125.245.165]) by kanga.kvack.org (Postfix) with SMTP id 5A4F36B0092 for ; Tue, 13 Mar 2012 14:10:24 -0400 (EDT) Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 13 Mar 2012 12:10:22 -0600 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 4158DC90050 for ; Tue, 13 Mar 2012 14:09:54 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2DI9pDE343368 for ; Tue, 13 Mar 2012 14:09:52 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2DI8nrZ006374 for ; Tue, 13 Mar 2012 15:08:51 -0300 Date: Tue, 13 Mar 2012 23:35:36 +0530 From: Srikar Dronamraju Subject: Re: [PATCH 2/2] uprobes/core: Handle breakpoint and singlestep exception. Message-ID: <20120313180536.GB21727@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20120313140303.17134.1401.sendpatchset@srdronam.in.ibm.com> <20120313140313.17134.52012.sendpatchset@srdronam.in.ibm.com> <20120313153524.GB12193@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20120313153524.GB12193@elte.hu> Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar Cc: Peter Zijlstra , Andrew Morton , Linus Torvalds , Ananth N Mavinakayanahalli , Jim Keniston , LKML , Linux-mm , Oleg Nesterov , Andi Kleen , Christoph Hellwig , Steven Rostedt , Arnaldo Carvalho de Melo , Masami Hiramatsu , Thomas Gleixner > > > diff --git a/kernel/fork.c b/kernel/fork.c > > index 26a7a67..36508b9 100644 > > --- a/kernel/fork.c > > +++ b/kernel/fork.c > > @@ -67,6 +67,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -731,6 +732,8 @@ void mm_release(struct task_struct *tsk, struct mm_struct *mm) > > exit_pi_state_list(tsk); > > #endif > > > > + uprobe_free_utask(tsk); > > + > > /* Get rid of any cached register state */ > > deactivate_mm(tsk, mm); > > > > @@ -1322,6 +1325,10 @@ static struct task_struct *copy_process(unsigned long clone_flags, > > INIT_LIST_HEAD(&p->pi_state_list); > > p->pi_state_cache = NULL; > > #endif > > +#ifdef CONFIG_UPROBES > > + p->utask = NULL; > > + p->uprobe_srcu_id = -1; > > +#endif > > /* > > * sigaltstack should be cleared when sharing the same VM > > */ > > Hm, I suspect by looking at the first two hunks you can guess > how the third hunk should be done more cleanly? > Resent just this patch after addressing this comment. -- thanks and regards Srikar -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org