From: Andrew Morton <akpm@linux-foundation.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
"n-horiguchi@ah.jp.nec.com" <n-horiguchi@ah.jp.nec.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
Glauber Costa <glommer@parallels.com>
Subject: Re: [PATCH] memcg: change behavior of moving charges at task move
Date: Thu, 22 Mar 2012 14:36:10 -0700 [thread overview]
Message-ID: <20120322143610.e4df49c9.akpm@linux-foundation.org> (raw)
In-Reply-To: <4F69A4C4.4080602@jp.fujitsu.com>
On Wed, 21 Mar 2012 18:52:04 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> static struct page *mc_handle_swap_pte(struct vm_area_struct *vma,
> unsigned long addr, pte_t ptent, swp_entry_t *entry)
> {
> - int usage_count;
> struct page *page = NULL;
> swp_entry_t ent = pte_to_swp_entry(ptent);
>
> if (!move_anon() || non_swap_entry(ent))
> return NULL;
> - usage_count = mem_cgroup_count_swap_user(ent, &page);
> - if (usage_count > 1) { /* we don't move shared anon */
> - if (page)
> - put_page(page);
> - return NULL;
> - }
> +#ifdef CONFIG_SWAP
> + /*
> + * Avoid lookup_swap_cache() not to update statistics.
> + */
I don't understand this comment - what is it trying to tell us?
> + page = find_get_page(&swapper_space, ent.val);
The code won't even compile if CONFIG_SWAP=n?
> +#endif
> if (do_swap_account)
> entry->val = ent.val;
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-22 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 9:52 [PATCH] memcg: change behavior of moving charges at task move KAMEZAWA Hiroyuki
2012-03-22 15:17 ` Naoya Horiguchi
2012-03-22 21:29 ` Andrew Morton
2012-03-23 0:05 ` KAMEZAWA Hiroyuki
2012-03-22 21:36 ` Andrew Morton [this message]
2012-03-23 0:18 ` KAMEZAWA Hiroyuki
2012-03-23 0:30 ` Andrew Morton
2012-03-23 0:52 ` KAMEZAWA Hiroyuki
2012-03-23 8:53 ` Johannes Weiner
2012-03-23 9:00 ` KAMEZAWA Hiroyuki
2012-03-23 9:45 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322143610.e4df49c9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).