From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx175.postini.com [74.125.245.175]) by kanga.kvack.org (Postfix) with SMTP id D25576B0044 for ; Fri, 30 Mar 2012 09:14:12 -0400 (EDT) Date: Fri, 30 Mar 2012 15:05:30 +0200 From: Oleg Nesterov Subject: Re: [PATCH 2/2] uprobes/core: counter to optimize probe hits. Message-ID: <20120330130530.GA16319@redhat.com> References: <20120321180811.22773.5801.sendpatchset@srdronam.in.ibm.com> <20120321180826.22773.57531.sendpatchset@srdronam.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120321180826.22773.57531.sendpatchset@srdronam.in.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Srikar Dronamraju Cc: Peter Zijlstra , Ingo Molnar , Andrew Morton , Linus Torvalds , Ananth N Mavinakayanahalli , Jim Keniston , LKML , Linux-mm , Andi Kleen , Christoph Hellwig , Steven Rostedt , Arnaldo Carvalho de Melo , Masami Hiramatsu , Thomas Gleixner On 03/21, Srikar Dronamraju wrote: > > + * uprobe_munmap() decrements the count if > + * - it sees a underlying breakpoint, (via is_swbp_at_addr) > + * (Subsequent unregister_uprobe wouldnt find the breakpoint > + * unless a uprobe_mmap kicks in, since the old vma would be > + * dropped just after uprobe_munmap.) > + * > + * register_uprobe increments the count if: > + * - it successfully adds a breakpoint. > + * > + * unregister_uprobe decrements the count if: Cosmetic nit, register_uprobe/unregister_uprobe do not exist. uprobe_register/unregister. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org