From: Andrew Morton <akpm@linux-foundation.org>
To: Sha Zhengju <handai.szj@gmail.com>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
kamezawa.hiroyu@jp.fujitsu.com, kirill@shutemov.name,
Sha Zhengju <handai.szj@taobao.com>
Subject: Re: [PATCH] memcg: revise the position of threshold index while unregistering event
Date: Thu, 5 Apr 2012 16:35:30 -0700 [thread overview]
Message-ID: <20120405163530.a1a9c9f9.akpm@linux-foundation.org> (raw)
In-Reply-To: <1331035943-7456-1-git-send-email-handai.szj@taobao.com>
On Tue, 6 Mar 2012 20:12:23 +0800
Sha Zhengju <handai.szj@gmail.com> wrote:
> From: Sha Zhengju <handai.szj@taobao.com>
>
> Index current_threshold should point to threshold just below or equal to usage.
> See below:
> http://www.spinics.net/lists/cgroups/msg00844.html
I have a bad feeling that I looked at a version of this patch
yesterday, but I can't find it.
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -4398,7 +4398,7 @@ static void mem_cgroup_usage_unregister_event(struct cgroup *cgrp,
> continue;
>
> new->entries[j] = thresholds->primary->entries[i];
> - if (new->entries[j].threshold < usage) {
> + if (new->entries[j].threshold <= usage) {
> /*
> * new->current_threshold will not be used
> * until rcu_assign_pointer(), so it's safe to increment
What were the runtime effects of this bug?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-05 23:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 12:12 [PATCH] memcg: revise the position of threshold index while unregistering event Sha Zhengju
2012-03-07 23:13 ` Kirill A. Shutemov
2012-03-08 5:44 ` KAMEZAWA Hiroyuki
2012-03-08 7:02 ` Sha Zhengju
2012-03-08 7:30 ` KAMEZAWA Hiroyuki
2012-03-08 9:37 ` Sha Zhengju
2012-04-05 23:35 ` Andrew Morton [this message]
2012-04-05 23:37 ` Andrew Morton
2012-04-06 3:59 ` Sha Zhengju
2012-04-06 4:04 ` [RESEND, PATCH] memcg: make threshold index in the right position Sha Zhengju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405163530.a1a9c9f9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=handai.szj@gmail.com \
--cc=handai.szj@taobao.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).