From: Mel Gorman <mgorman@suse.de>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-mm@kvack.org, Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 2/2] mm: compaction: allow isolation of lower order buddy pages
Date: Tue, 10 Apr 2012 11:40:50 +0100 [thread overview]
Message-ID: <20120410104050.GF3789@suse.de> (raw)
In-Reply-To: <1333643534-1591-3-git-send-email-b.zolnierkie@samsung.com>
On Thu, Apr 05, 2012 at 06:32:13PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Allow lower order buddy pages in suitable_migration_target()
> so isolate_freepages() can isolate them as free pages during
> compaction_alloc() phase.
>
> Cc: Mel Gorman <mgorman@suse.de>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Nak.
This patch depends on patch 1 to scan every page in isolate_freepages()
and I explained why that is a problem already. That aside, a side-effect
of this is that movable pages can get migrated to MIGRATE_UNMOVABLE
and MIGRATE_RECLAIMABLE pageblocks. This will have a negative impact on
fragmentation avoidance. In your particular use-case it will slightly
increase allocation success rates early in the lifetime of the system at
the cost of degrading success rates later.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-04-10 10:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 16:32 [PATCH 0/2] mm: compaction: improve free pages selection Bartlomiej Zolnierkiewicz
2012-04-05 16:32 ` [PATCH 1/2] mm: compaction: try harder to isolate free pages Bartlomiej Zolnierkiewicz
2012-04-06 6:40 ` Minchan Kim
2012-04-06 8:21 ` Bartlomiej Zolnierkiewicz
2012-04-06 8:51 ` Minchan Kim
2012-04-10 10:38 ` Mel Gorman
2012-04-12 5:42 ` Mel Gorman
2012-04-05 16:32 ` [PATCH 2/2] mm: compaction: allow isolation of lower order buddy pages Bartlomiej Zolnierkiewicz
2012-04-05 21:46 ` David Rientjes
2012-04-06 8:38 ` Bartlomiej Zolnierkiewicz
2012-04-06 6:45 ` Minchan Kim
2012-04-10 10:40 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410104050.GF3789@suse.de \
--to=mgorman@suse.de \
--cc=b.zolnierkie@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).