From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jim Keniston <jkenisto@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux-mm <linux-mm@kvack.org>, Oleg Nesterov <oleg@redhat.com>,
Andi Kleen <andi@firstfloor.org>,
Christoph Hellwig <hch@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Thomas Gleixner <tglx@linutronix.de>,
Anton Arapov <anton@redhat.com>
Subject: Re: [PATCH] perf/probe: Provide perf interface for uprobes
Date: Wed, 11 Apr 2012 15:17:28 -0300 [thread overview]
Message-ID: <20120411181727.GK16257@infradead.org> (raw)
In-Reply-To: <20120411170343.GB29831@linux.vnet.ibm.com>
Em Wed, Apr 11, 2012 at 10:42:25PM +0530, Srikar Dronamraju escreveu:
> * Arnaldo Carvalho de Melo <acme@infradead.org> [2012-04-11 11:49:18]:
> > Em Wed, Apr 11, 2012 at 07:27:42PM +0530, Srikar Dronamraju escreveu:
> > > From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> > >
> > > - Enhances perf to probe user space executables and libraries.
> > > - Enhances -F/--funcs option of "perf probe" to list possible probe points in
> > > an executable file or library.
> > > - Documents userspace probing support in perf.
> > >
> > > [ Probing a function in the executable using function name ]
> > > perf probe -x /bin/zsh zfree
> >
> > Can we avoid the need for -x? I.e. we could figure out it is userspace
> > and act accordingly.
>
> To list the functions in the module ipv6, we use "perf probe -F -m ipv6"
> So I used the same logic to use -x for specifying executables.
>
> This is in agreement with probepoint addition where without any
> additional options would mean kernel probepoint; m option would mean
> module and x option would mean user space executable.
>
> However if you still think we should change, do let me know.
Yeah, if one needs to disambiguate, sure, use these keywords, but for
things like:
$ perf probe /lib/libc.so.6 malloc
I think it is easy to figure out it is userspace. I.e. some regex would
figure it out.
Anyway this can be done in a follow up patch.
- Arnaldo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-11 18:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 13:57 [PATCH] perf/probe: Provide perf interface for uprobes Srikar Dronamraju
2012-04-11 14:49 ` Arnaldo Carvalho de Melo
2012-04-11 17:12 ` Srikar Dronamraju
2012-04-11 18:17 ` Arnaldo Carvalho de Melo [this message]
2012-04-12 3:27 ` Masami Hiramatsu
2012-04-12 14:07 ` Arnaldo Carvalho de Melo
2012-04-12 14:41 ` Srikar Dronamraju
2012-04-12 15:56 ` Arnaldo Carvalho de Melo
2012-04-12 15:10 ` Srikar Dronamraju
2012-04-13 6:27 ` Masami Hiramatsu
2012-04-14 1:13 ` Arnaldo Carvalho de Melo
2012-04-16 12:27 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411181727.GK16257@infradead.org \
--to=acme@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=andi@firstfloor.org \
--cc=anton@redhat.com \
--cc=hch@infradead.org \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).