From: Mel Gorman <mgorman@suse.de>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-mm@kvack.org, Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 1/2] mm: compaction: try harder to isolate free pages
Date: Thu, 12 Apr 2012 06:42:33 +0100 [thread overview]
Message-ID: <20120412054233.GJ3789@suse.de> (raw)
In-Reply-To: <20120410103833.GE3789@suse.de>
On Tue, Apr 10, 2012 at 11:38:33AM +0100, Mel Gorman wrote:
> I think the bug you are accidentally fixing is related to how high_pfn
> is updated inside that loop. The intent is that when free pages are
> isolated that the next scan started from the same place as page
> migration may have released those pages again. As it gets updated every
> time a page is isolated the scanner is moving faster than it should.
>
> Try this;
>
That patch is obviously wrong so you're still looking for some other
side-effect of your patch that explains why it appears to behave better.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-12 5:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 16:32 [PATCH 0/2] mm: compaction: improve free pages selection Bartlomiej Zolnierkiewicz
2012-04-05 16:32 ` [PATCH 1/2] mm: compaction: try harder to isolate free pages Bartlomiej Zolnierkiewicz
2012-04-06 6:40 ` Minchan Kim
2012-04-06 8:21 ` Bartlomiej Zolnierkiewicz
2012-04-06 8:51 ` Minchan Kim
2012-04-10 10:38 ` Mel Gorman
2012-04-12 5:42 ` Mel Gorman [this message]
2012-04-05 16:32 ` [PATCH 2/2] mm: compaction: allow isolation of lower order buddy pages Bartlomiej Zolnierkiewicz
2012-04-05 21:46 ` David Rientjes
2012-04-06 8:38 ` Bartlomiej Zolnierkiewicz
2012-04-06 6:45 ` Minchan Kim
2012-04-10 10:40 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412054233.GJ3789@suse.de \
--to=mgorman@suse.de \
--cc=b.zolnierkie@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).