From: Fengguang Wu <fengguang.wu@intel.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: Re: [PATCH] mm: page-writeback.c: local functions should not be exposed globally
Date: Sat, 14 Apr 2012 17:42:22 +0800 [thread overview]
Message-ID: <20120414094222.GA19710@localhost> (raw)
In-Reply-To: <201204121344.20613.hartleys@visionengravers.com>
On Thu, Apr 12, 2012 at 01:44:20PM -0700, H Hartley Sweeten wrote:
> The function global_dirtyable_memory is only referenced in this file and
> should be marked static to prevent it from being exposed globally.
>
> This quiets the sparse warning:
>
> warning: symbol 'global_dirtyable_memory' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Applied, thanks!
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-04-14 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 20:44 [PATCH] mm: page-writeback.c: local functions should not be exposed globally H Hartley Sweeten
2012-04-14 9:42 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120414094222.GA19710@localhost \
--to=fengguang.wu@intel.com \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).