From: Andrew Morton <akpm@linux-foundation.org>
To: Sasikanth babu <sasikanth.v19@gmail.com>
Cc: Tejun Heo <tj@kernel.org>, "H. Peter Anvin" <hpa@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: memblock - Handled failure of debug fs entries creation
Date: Sat, 28 Apr 2012 12:06:57 -0700 [thread overview]
Message-ID: <20120428120657.4982a248.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAOJFanUu_RD2UNgFg4gNuPte+jOA95ejMtq53UCo6vLaLohmQQ@mail.gmail.com>
On Sun, 29 Apr 2012 00:32:26 +0530 Sasikanth babu <sasikanth.v19@gmail.com> wrote:
> > Fact is, debugfs_create_dir() and debugfs_create_file() are stupid
> > interfaces which don't provide the caller (and hence the user) with any
> > information about why they failed. Perhaps memblock_init_debugfs()
> > should return -EWESUCK.
> >
>
> I'm working on a patch which address this issue. debugfs_create_XXX
> calls
> will return proper error codes, and fixing the existing code not each
> and every part but the code
> which handles the values returned by debufs_create_XXX otherwise it will
> break the existing
> functionality .
Excellent!
> (any suggestions or opinions ?)
Well, don't modify the existing interfaces: create new ones and we can
migrate gradually. But you're probably already doing that.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-28 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 19:59 [PATCH 2/2] mm: memblock - Handled failure of debug fs entries creation Sasikantha babu
2012-04-26 23:21 ` Andrew Morton
2012-04-28 19:02 ` Sasikanth babu
2012-04-28 19:06 ` Andrew Morton [this message]
2012-04-28 19:45 ` Sasikanth babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120428120657.4982a248.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=sasikanth.v19@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).