From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx150.postini.com [74.125.245.150]) by kanga.kvack.org (Postfix) with SMTP id 4C6306B0044 for ; Mon, 7 May 2012 10:47:27 -0400 (EDT) Date: Mon, 7 May 2012 22:47:15 +0800 From: Fengguang Wu Subject: Re: [PATCH 2/2] block: Convert BDI proportion calculations to flexible proportions Message-ID: <20120507144715.GB13983@localhost> References: <1336084760-19534-1-git-send-email-jack@suse.cz> <1336084760-19534-3-git-send-email-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1336084760-19534-3-git-send-email-jack@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Jan Kara Cc: linux-mm@kvack.org, peterz@infradead.org On Fri, May 04, 2012 at 12:39:20AM +0200, Jan Kara wrote: > Convert calculations of proportion of writeback each bdi does to new flexible > proportion code. That allows us to use aging period of fixed wallclock time > which gives better proportion estimates given the hugely varying throughput of > different devices. > > Signed-off-by: Jan Kara > --- > include/linux/backing-dev.h | 6 ++-- > mm/backing-dev.c | 5 +-- > mm/page-writeback.c | 80 ++++++++++++++++++++---------------------- > 3 files changed, 43 insertions(+), 48 deletions(-) > +static void vm_completions_period(struct work_struct *work); > +/* Work for aging of vm_completions */ > +static DECLARE_DEFERRED_WORK(vm_completions_period_work, vm_completions_period); > + > +static void vm_completions_period(struct work_struct *work) > +{ > + fprop_new_period(&vm_completions); > + schedule_delayed_work(&vm_completions_period_work, > + VM_COMPLETIONS_PERIOD_LEN); > +} > + Is it possible to optimize away the periodic work when there are no disk writes? Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org