From: Sam Ravnborg <sam@ravnborg.org>
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Patch 3/4] memblock: limit memory address from memblock
Date: Mon, 14 May 2012 18:52:21 +0200 [thread overview]
Message-ID: <20120514165221.GA14426@merkur.ravnborg.org> (raw)
In-Reply-To: <4FB0F37E.2040805@jp.fujitsu.com>
On Mon, May 14, 2012 at 08:58:54PM +0900, Yasuaki Ishimatsu wrote:
> Setting kernelcore_max_pfn means all memory which is bigger than
> the boot parameter is allocated as ZONE_MOVABLE. So memory which
> is allocated by memblock also should be limited by the parameter.
>
> The patch limits memory from memblock.
I see no reason why we need two limits for memblock.
And if we really require two limits then please use a function
to set it.
All other setup/etc. towoards memblock is via function,
and starting to introduce magic variables is confusing.
Also new stuff in memblock shal have a nice comment
describing the usage. that we in the past has failed to
do so is no excuse.
Sam
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-14 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 5:46 [PATCH] memory: add kernelcore_max_addr boot option Lai Jiangshan
2012-05-11 20:39 ` Andrew Morton
2012-05-14 2:33 ` Yasuaki Ishimatsu
2012-05-14 11:50 ` Yasuaki Ishimatsu
2012-05-14 11:58 ` [Patch 1/4] x86: get pg_data_t's memory from other node Yasuaki Ishimatsu
2012-05-14 11:58 ` [Patch 2/4] x86: use memblock_set_current_limit() to set memblock.current_limit Yasuaki Ishimatsu
2012-05-14 11:58 ` [Patch 3/4] memblock: limit memory address from memblock Yasuaki Ishimatsu
2012-05-14 16:52 ` Sam Ravnborg [this message]
2012-05-14 11:59 ` [Patch 4/4] memblock: compare current_limit with end variable at memblock_find_in_range_node() Yasuaki Ishimatsu
2012-05-14 12:01 ` [PATCH] memory: add kernelcore_max_addr boot option Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514165221.GA14426@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).