From: Andrew Morton <akpm@linux-foundation.org>
To: KyongHo <pullip.cho@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: mm: fix faulty initialization in vmalloc_init()
Date: Thu, 24 May 2012 15:12:31 -0700 [thread overview]
Message-ID: <20120524151231.e3a18ac5.akpm@linux-foundation.org> (raw)
In-Reply-To: <001c01cd3987$d1a71a50$74f54ef0$%cho@samsung.com>
On Thu, 24 May 2012 17:32:56 +0900
KyongHo <pullip.cho@samsung.com> wrote:
> vmalloc_init() adds 'vmap_area's for early 'vm_struct's.
> This patch fixes vmalloc_init() to correctly initialize
> vmap_area for the given vm_struct.
>
<daily message>
Insufficient information. When fixing a bug please always always
always describe the user-visible effects of the bug. Does the kernel
instantly crash? Is it a comestic cleanliness thing which has no
effect? Something in between? I have simply no idea, and am dependent
upon you to tell me.
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1185,9 +1185,10 @@ void __init vmalloc_init(void)
> /* Import existing vmlist entries. */
> for (tmp = vmlist; tmp; tmp = tmp->next) {
> va = kzalloc(sizeof(struct vmap_area), GFP_NOWAIT);
> - va->flags = tmp->flags | VM_VM_AREA;
> + va->flags = VM_VM_AREA;
This change is a mystery. Why do we no longer transfer ->flags?
> va->va_start = (unsigned long)tmp->addr;
> va->va_end = va->va_start + tmp->size;
> + va->vm = tmp;
OK, I can see how this might be important. But why did you find it
necessary? Why was this change actually needed?
> __insert_vmap_area(va);
> }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-24 22:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 8:32 mm: fix faulty initialization in vmalloc_init() KyongHo
2012-05-24 22:12 ` Andrew Morton [this message]
2012-05-25 0:24 ` Olav Haugan
2012-05-25 11:12 ` KyongHo Cho
2012-05-25 12:39 ` KyongHo Cho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120524151231.e3a18ac5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pullip.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).