From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: 'KOSAKI Motohiro' <kosaki.motohiro@gmail.com>,
'Paul Mundt' <lethal@linux-sh.org>,
'Minchan Kim' <minchan@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
'Kyungmin Park' <kyungmin.park@samsung.com>,
'Arnd Bergmann' <arnd@arndb.de>,
'Russell King - ARM Linux' <linux@arm.linux.org.uk>,
'Chunsang Jeong' <chunsang.jeong@linaro.org>,
'Krishna Reddy' <vdumpa@nvidia.com>,
'Hiroshi Doyu' <hdoyu@nvidia.com>,
'Subash Patel' <subashrp@gmail.com>,
'Nick Piggin' <npiggin@gmail.com>
Subject: Re: [PATCHv2 3/4] mm: vmalloc: add VM_DMA flag to indicate areas used by dma-mapping framework
Date: Tue, 29 May 2012 11:07:14 -0400 [thread overview]
Message-ID: <20120529150714.GA8293@phenom.dumpdata.com> (raw)
In-Reply-To: <001d01cd3caa$a05d0510$e1170f30$%szyprowski@samsung.com>
On Mon, May 28, 2012 at 10:19:39AM +0200, Marek Szyprowski wrote:
> Hello,
>
> On Sunday, May 27, 2012 2:35 PM KOSAKI Motohiro wrote:
>
> > On Thu, May 24, 2012 at 8:28 AM, Paul Mundt <lethal@linux-sh.org> wrote:
> > > On Thu, May 24, 2012 at 02:26:12PM +0200, Marek Szyprowski wrote:
> > >> On Tuesday, May 22, 2012 9:08 AM Minchan Kim wrote:
> > >> > Hmm, VM_DMA would become generic flag?
> > >> > AFAIU, maybe VM_DMA would be used only on ARM arch.
> > >>
> > >> Right now yes, it will be used only on ARM architecture, but maybe other architecture will
> > >> start using it once it is available.
> > >>
> > > There's very little about the code in question that is ARM-specific to
> > > begin with. I plan to adopt similar changes on SH once the work has
> > > settled one way or the other, so we'll probably use the VMA flag there,
> > > too.
> >
> > I don't think VM_DMA is good idea because x86_64 has two dma zones. x86 unaware
> > patches make no sense.
>
> I see no problems to add VM_DMA64 later if x86_64 starts using vmalloc areas for creating
> kernel mappings for the dma buffers (I assume that there are 2 dma zones: one 32bit and one
> 64bit). Right now x86 and x86_64 don't use vmalloc areas for dma buffers, so I hardly see
> how this patch can be considered as 'x86 unaware'.
Well they do - kind off. It is usually done by calling vmalloc_32 and then using
the DMA API on top of those pages (or sometimes the non-portable virt_to_phys macro).
Introducing this and replacing the vmalloc_32 with this seems like a nice step in making
those device drivers APIs more portable?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-29 15:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 10:54 [PATCHv2 0/4] ARM: replace custom consistent dma region with vmalloc Marek Szyprowski
2012-05-17 10:54 ` [PATCHv2 1/4] mm: vmalloc: use const void * for caller argument Marek Szyprowski
2012-05-22 6:58 ` Minchan Kim
2012-05-17 10:54 ` [PATCHv2 2/4] mm: vmalloc: export find_vm_area() function Marek Szyprowski
2012-05-22 7:01 ` Minchan Kim
2012-05-17 10:54 ` [PATCHv2 3/4] mm: vmalloc: add VM_DMA flag to indicate areas used by dma-mapping framework Marek Szyprowski
2012-05-22 7:07 ` Minchan Kim
2012-05-24 12:26 ` Marek Szyprowski
2012-05-24 12:28 ` Paul Mundt
2012-05-27 12:35 ` KOSAKI Motohiro
2012-05-28 8:19 ` Marek Szyprowski
2012-05-29 15:07 ` Konrad Rzeszutek Wilk [this message]
2012-05-17 10:54 ` [PATCHv2 4/4] ARM: dma-mapping: remove custom consistent dma region Marek Szyprowski
2012-05-22 7:33 ` Minchan Kim
2012-05-22 12:50 ` Marek Szyprowski
2012-05-30 0:11 ` KOSAKI Motohiro
2012-05-30 7:15 ` Marek Szyprowski
2012-05-30 7:22 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120529150714.GA8293@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=arnd@arndb.de \
--cc=chunsang.jeong@linaro.org \
--cc=hdoyu@nvidia.com \
--cc=kosaki.motohiro@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=lethal@linux-sh.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=minchan@kernel.org \
--cc=npiggin@gmail.com \
--cc=subashrp@gmail.com \
--cc=vdumpa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).