From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx175.postini.com [74.125.245.175]) by kanga.kvack.org (Postfix) with SMTP id A58336B0062 for ; Tue, 29 May 2012 12:39:21 -0400 (EDT) Date: Tue, 29 May 2012 18:38:49 +0200 From: Andrea Arcangeli Subject: Re: [PATCH 13/35] autonuma: add page structure fields Message-ID: <20120529163849.GF21339@redhat.com> References: <1337965359-29725-1-git-send-email-aarcange@redhat.com> <1337965359-29725-14-git-send-email-aarcange@redhat.com> <1338297385.26856.74.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1338297385.26856.74.camel@twins> Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hillf Danton , Dan Smith , Linus Torvalds , Andrew Morton , Thomas Gleixner , Ingo Molnar , Paul Turner , Suresh Siddha , Mike Galbraith , "Paul E. McKenney" , Lai Jiangshan , Bharata B Rao , Lee Schermerhorn , Rik van Riel , Johannes Weiner , Srivatsa Vaddagiri , Christoph Lameter On Tue, May 29, 2012 at 03:16:25PM +0200, Peter Zijlstra wrote: > 24 bytes per page.. or ~0.6% of memory gone. This is far too great a > price to pay. I don't think it's too great, memcg uses for half of that and yet nobody is booting with cgroup_disable=memory even on not-NUMA servers with less RAM. > At LSF/MM Rik already suggested you limit the number of pages that can > be migrated concurrently and use this to move the extra list_head out of > struct page and into a smaller amount of extra structures, reducing the > total overhead. It would reduce the memory overhead but it'll make the code more complex and it'll require more locking, plus allowing for very long migration lrus, provides an additional means of false-sharing avoidance. Those are lrus, if the last_nid false sharing logic will pass, the page still has to reach the tail of the list before being migrated, if false sharing happens in the meanwhile we'll remove it from the lru. But I'm all for experimenting. It's just not something I had the time to try yet. I will certainly love to see how it performs by reducing the max size of the list. I totally agree it's a good idea to try it out, and I don't exclude it will work fine, but it's not obvious it's worth the memory saving. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org