From: Christoph Lameter <cl@linux.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Matt Mackall <mpm@selenic.com>,
Glauber Costa <glommer@parallels.com>,
Joonsoo Kim <js1304@gmail.com>
Subject: Common [04/20] [slab] Use page struct fields instead of casting
Date: Fri, 01 Jun 2012 14:52:49 -0500 [thread overview]
Message-ID: <20120601195301.856836483@linux.com> (raw)
In-Reply-To: 20120601195245.084749371@linux.com
[-- Attachment #1: slab_page_struct_fields --]
[-- Type: text/plain, Size: 2265 bytes --]
Add fields to the page struct so that it is properly documented that
slab overlays the lru fields.
This cleans up some casts in slab.
Reviewed-by: Glauber Costa <glommer@parallels.com>
Reviewed-by: Joonsoo Kim <js1304@gmail.com>
Signed-off-by: Christoph Lameter <cl@linux.com>
---
include/linux/mm_types.h | 4 ++++
mm/slab.c | 8 ++++----
2 files changed, 8 insertions(+), 4 deletions(-)
Index: linux-2.6/mm/slab.c
===================================================================
--- linux-2.6.orig/mm/slab.c 2012-06-01 02:57:10.719019693 -0500
+++ linux-2.6/mm/slab.c 2012-06-01 02:57:14.875019607 -0500
@@ -496,25 +496,25 @@ static bool slab_max_order_set __initdat
*/
static inline void page_set_cache(struct page *page, struct kmem_cache *cache)
{
- page->lru.next = (struct list_head *)cache;
+ page->slab_cache = cache;
}
static inline struct kmem_cache *page_get_cache(struct page *page)
{
page = compound_head(page);
BUG_ON(!PageSlab(page));
- return (struct kmem_cache *)page->lru.next;
+ return page->slab_cache;
}
static inline void page_set_slab(struct page *page, struct slab *slab)
{
- page->lru.prev = (struct list_head *)slab;
+ page->slab_page = slab;
}
static inline struct slab *page_get_slab(struct page *page)
{
BUG_ON(!PageSlab(page));
- return (struct slab *)page->lru.prev;
+ return page->slab_page;
}
static inline struct kmem_cache *virt_to_cache(const void *obj)
Index: linux-2.6/include/linux/mm_types.h
===================================================================
--- linux-2.6.orig/include/linux/mm_types.h 2012-06-01 02:57:12.735019652 -0500
+++ linux-2.6/include/linux/mm_types.h 2012-06-01 03:00:05.031016077 -0500
@@ -110,6 +110,10 @@ struct page {
};
struct list_head list; /* slobs list of pages */
+ struct { /* slab fields */
+ struct kmem_cache *slab_cache;
+ struct slab *slab_page;
+ };
};
/* Remainder is not double word aligned */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-01 19:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 19:52 Common [00/20] Sl[auo]b: Common code rework V4 Christoph Lameter
2012-06-01 19:52 ` Common [01/20] [slob] Define page struct fields used in mm_types.h Christoph Lameter
2012-06-01 19:52 ` Common [03/20] [slob] Remove various small accessors Christoph Lameter
2012-06-01 19:52 ` Christoph Lameter [this message]
2012-06-01 19:52 ` Common [05/20] [slab] Remove some accessors Christoph Lameter
2012-06-01 19:52 ` Common [06/20] Extract common fields from struct kmem_cache Christoph Lameter
2012-06-01 19:52 ` Common [07/20] [slab] Get rid of obj_size macro Christoph Lameter
2012-06-01 19:52 ` Common [08/20] Extract common code for kmem_cache_create() Christoph Lameter
2012-06-01 19:52 ` Common [09/20] Common definition for boot state of the slab allocators Christoph Lameter
2012-06-01 19:52 ` Common [10/20] Use a common mutex definition Christoph Lameter
2012-06-01 19:52 ` Common [11/20] Move kmem_cache_create mutex handling to common code Christoph Lameter
2012-06-01 19:52 ` Common [13/20] Extract a common function for kmem_cache_destroy Christoph Lameter
2012-07-31 12:01 ` Glauber Costa
2012-07-31 14:12 ` Christoph Lameter
2012-07-31 14:16 ` Glauber Costa
2012-07-31 14:42 ` Christoph Lameter
2012-07-31 14:47 ` Glauber Costa
2012-07-31 16:30 ` Christoph Lameter
2012-07-31 16:41 ` Glauber Costa
2012-07-31 16:52 ` Christoph Lameter
2012-06-01 19:52 ` Common [14/20] Always use the name "kmem_cache" for the slab cache with the kmem_cache structure Christoph Lameter
2012-06-01 19:53 ` Common [16/20] Get rid of __kmem_cache_destroy Christoph Lameter
2012-06-01 19:53 ` Common [17/20] Move duping of slab name to slab_common.c Christoph Lameter
2012-06-01 19:53 ` Common [18/20] Do slab aliasing call from common code Christoph Lameter
2012-06-01 19:53 ` Common [19/20] Allocate kmem_cache structure in slab_common.c Christoph Lameter
2012-06-01 19:53 ` Common [20/20] Common alignment code Christoph Lameter
-- strict thread matches above, loose matches on Subject: below --
2012-06-13 15:24 Common [00/20] Sl[auo]b: Common code rework V5 (for merge) Christoph Lameter
2012-06-13 15:24 ` Common [04/20] [slab] Use page struct fields instead of casting Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601195301.856836483@linux.com \
--to=cl@linux.com \
--cc=glommer@parallels.com \
--cc=js1304@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).