From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx203.postini.com [74.125.245.203]) by kanga.kvack.org (Postfix) with SMTP id 6B7066B005C for ; Sun, 3 Jun 2012 18:13:36 -0400 (EDT) Date: Sun, 3 Jun 2012 18:13:26 -0400 From: Dave Jones Subject: Re: WARNING: at mm/page-writeback.c:1990 __set_page_dirty_nobuffers+0x13a/0x170() Message-ID: <20120603221326.GA7707@redhat.com> References: <20120601161205.GA1918@redhat.com> <20120601171606.GA3794@redhat.com> <20120603181548.GA306@redhat.com> <20120603183139.GA1061@redhat.com> <20120603205332.GA5412@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: Hugh Dickins , Bartlomiej Zolnierkiewicz , Kyungmin Park , Marek Szyprowski , Mel Gorman , Minchan Kim , Rik van Riel , Andrew Morton , Cong Wang , Markus Trippelsdorf , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Sun, Jun 03, 2012 at 02:59:22PM -0700, Linus Torvalds wrote: > On Sun, Jun 3, 2012 at 1:53 PM, Dave Jones wrote: > > > > running just over two hours with that commit reverted with no obvious ill effects so far. > > And how quickly have you usually seen the problems? Would you have > considered two ours "good" in your bisection thing? Yeah, usually see something go awry in an hour or less. > Also, just to check: Hugh sent out a patch called "mm: fix warning in > __set_page_dirty_nobuffers". Is that applied in your tree too, or did > the __set_page_dirty_nobuffers() warning go away with just the revert? That is applied. Otherwise I see the warning he refers to. > I'm just trying to figure out exactly what you are testing. When you > said "test with that (and Hugh's last patch) backed out", the "and > Hugh's last patch" part was a bit ambiguous. Do you mean the trial > patch in this thread (backed out) or do you mean "*with* Hugh's patch > for the __set_page_dirty_nobuffers() warning". The former. (This). --- 3.4.0+/mm/compaction.c 2012-05-30 08:17:19.396008280 -0700 +++ linux/mm/compaction.c 2012-06-01 20:59:56.840204915 -0700 @@ -369,6 +369,8 @@ static bool rescue_unmovable_pageblock(s { unsigned long pfn, start_pfn, end_pfn; struct page *start_page, *end_page; + struct zone *zone; + unsigned long flags; pfn = page_to_pfn(page); start_pfn = pfn & ~(pageblock_nr_pages - 1); @@ -378,7 +380,8 @@ static bool rescue_unmovable_pageblock(s end_page = pfn_to_page(end_pfn); /* Do not deal with pageblocks that overlap zones */ - if (page_zone(start_page) != page_zone(end_page)) + zone = page_zone(start_page); + if (zone != page_zone(end_page)) return false; for (page = start_page, pfn = start_pfn; page < end_page; pfn++, @@ -399,8 +402,10 @@ static bool rescue_unmovable_pageblock(s return false; } + spin_lock_irqsave(&zone->lock, flags); set_pageblock_migratetype(page, MIGRATE_MOVABLE); - move_freepages_block(page_zone(page), page, MIGRATE_MOVABLE); + move_freepages_block(zone, page, MIGRATE_MOVABLE); + spin_unlock_irqrestore(&zone->lock, flags); return true; I do see something else weird going on, but it seems like an unrelated problem. I have a lot of processes hanging after calling sys_renameat. I'll dig some more on that, and post a follow-up. Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org