From: Andrew Morton <akpm@linux-foundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Konstantin Khlebnikov <khlebnikov@openvz.org>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: a whole bunch of crashes since todays -mm merge.
Date: Thu, 7 Jun 2012 18:05:15 -0700 [thread overview]
Message-ID: <20120607180515.4afffc89.akpm@linux-foundation.org> (raw)
In-Reply-To: <CA+55aFzivM8Z1Bjk3Qo2vtnQhCQ7fQ4rf_a+EXY7noXQcxL_CA@mail.gmail.com>
On Thu, 7 Jun 2012 17:52:52 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Thu, Jun 7, 2012 at 5:24 PM, Dave Jones <davej@redhat.com> wrote:
> > I just started seeing crashes while doing simple things, like logging on a console..
>
> I'm looking at it right now, and the sync_mm_rss() patch is pure
> garbage. In many ways.
>
> You can't do sync_mm_rss() from mmdrop(), because there's no reason to
> believe that the task that does mmdrop() does it on its own active_mm.
> And even if you *could* do it there, it's still horribly wrong,
> because it does it at the end *after* it already freed the mm!
>
> Does it go away if you revert that (commit 40af1bbdca47). I wish I
> hadn't merged it, or that I had noticed how horrible it was before I
> pushed out.
>
It appears this is due to me fat-fingering conflict resolution last
week. That hunk is supposed to be in mm_release(), not mmput().
It's probably best to throw the patch away for now - we'll try again.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-08 1:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 0:24 a whole bunch of crashes since todays -mm merge Dave Jones
2012-06-08 0:52 ` Linus Torvalds
2012-06-08 1:00 ` Dave Jones
2012-06-08 1:06 ` Linus Torvalds
2012-06-08 1:12 ` Dave Jones
2012-06-08 1:25 ` Linus Torvalds
2012-06-08 1:05 ` Andrew Morton [this message]
2012-06-08 1:09 ` Linus Torvalds
2012-06-08 2:22 ` Dave Jones
2012-06-08 1:39 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607180515.4afffc89.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).