linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Wanpeng Li <liwp.linux@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Gavin Shan <shangw@linux.vnet.ibm.com>,
	Wanpeng Li <liwp@linux.vnet.ibm.com>
Subject: Re: [PATCH] mm/page-writeback.c: fix comments error in page-writeback.c
Date: Sat, 9 Jun 2012 19:54:13 +0800	[thread overview]
Message-ID: <20120609115413.GA15811@localhost> (raw)
In-Reply-To: <1339242333-3080-1-git-send-email-liwp.linux@gmail.com>

On Sat, Jun 09, 2012 at 07:45:33PM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
> 
> Signed-off-by: Wanpeng Li <liwp@linux.vnet.ibm.com>
> ---
>  mm/page-writeback.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 93d8d2f..c833bf0 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -930,7 +930,7 @@ static void bdi_update_dirty_ratelimit(struct backing_dev_info *bdi,
>  	 */
>  
>  	/*
> -	 * dirty_ratelimit will follow balanced_dirty_ratelimit iff
> +	 * dirty_ratelimit will follow balanced_dirty_ratelimit if

That 'iff' means 'if and only if'.

>  	 * task_ratelimit is on the same side of dirty_ratelimit, too.
>  	 * For example, when
>  	 * - dirty_ratelimit > balanced_dirty_ratelimit
> @@ -941,7 +941,7 @@ static void bdi_update_dirty_ratelimit(struct backing_dev_info *bdi,
>  	 * feel and care are stable dirty rate and small position error.
>  	 *
>  	 * |task_ratelimit - dirty_ratelimit| is used to limit the step size
> -	 * and filter out the sigular points of balanced_dirty_ratelimit. Which
> +	 * and filter out the singular points of balanced_dirty_ratelimit. Which
>  	 * keeps jumping around randomly and can even leap far away at times
>  	 * due to the small 200ms estimation period of dirty_rate (we want to
>  	 * keep that period small to reduce time lags).

I'll fold the above chunk into the previous patch.

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2012-06-09 11:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-09 11:45 [PATCH] mm/page-writeback.c: fix comments error in page-writeback.c Wanpeng Li
2012-06-09 11:54 ` Fengguang Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120609115413.GA15811@localhost \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liwp.linux@gmail.com \
    --cc=liwp@linux.vnet.ibm.com \
    --cc=shangw@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).