linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/page-writeback.c: fix comments error in page-writeback.c
@ 2012-06-09 11:45 Wanpeng Li
  2012-06-09 11:54 ` Fengguang Wu
  0 siblings, 1 reply; 2+ messages in thread
From: Wanpeng Li @ 2012-06-09 11:45 UTC (permalink / raw)
  To: Fengguang Wu
  Cc: Andrew Morton, linux-kernel, linux-mm, Gavin Shan, Wanpeng Li,
	Wanpeng Li

From: Wanpeng Li <liwp@linux.vnet.ibm.com>

Signed-off-by: Wanpeng Li <liwp@linux.vnet.ibm.com>
---
 mm/page-writeback.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 93d8d2f..c833bf0 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -930,7 +930,7 @@ static void bdi_update_dirty_ratelimit(struct backing_dev_info *bdi,
 	 */
 
 	/*
-	 * dirty_ratelimit will follow balanced_dirty_ratelimit iff
+	 * dirty_ratelimit will follow balanced_dirty_ratelimit if
 	 * task_ratelimit is on the same side of dirty_ratelimit, too.
 	 * For example, when
 	 * - dirty_ratelimit > balanced_dirty_ratelimit
@@ -941,7 +941,7 @@ static void bdi_update_dirty_ratelimit(struct backing_dev_info *bdi,
 	 * feel and care are stable dirty rate and small position error.
 	 *
 	 * |task_ratelimit - dirty_ratelimit| is used to limit the step size
-	 * and filter out the sigular points of balanced_dirty_ratelimit. Which
+	 * and filter out the singular points of balanced_dirty_ratelimit. Which
 	 * keeps jumping around randomly and can even leap far away at times
 	 * due to the small 200ms estimation period of dirty_rate (we want to
 	 * keep that period small to reduce time lags).
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm/page-writeback.c: fix comments error in page-writeback.c
  2012-06-09 11:45 [PATCH] mm/page-writeback.c: fix comments error in page-writeback.c Wanpeng Li
@ 2012-06-09 11:54 ` Fengguang Wu
  0 siblings, 0 replies; 2+ messages in thread
From: Fengguang Wu @ 2012-06-09 11:54 UTC (permalink / raw)
  To: Wanpeng Li; +Cc: Andrew Morton, linux-kernel, linux-mm, Gavin Shan, Wanpeng Li

On Sat, Jun 09, 2012 at 07:45:33PM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <liwp@linux.vnet.ibm.com>
> 
> Signed-off-by: Wanpeng Li <liwp@linux.vnet.ibm.com>
> ---
>  mm/page-writeback.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 93d8d2f..c833bf0 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -930,7 +930,7 @@ static void bdi_update_dirty_ratelimit(struct backing_dev_info *bdi,
>  	 */
>  
>  	/*
> -	 * dirty_ratelimit will follow balanced_dirty_ratelimit iff
> +	 * dirty_ratelimit will follow balanced_dirty_ratelimit if

That 'iff' means 'if and only if'.

>  	 * task_ratelimit is on the same side of dirty_ratelimit, too.
>  	 * For example, when
>  	 * - dirty_ratelimit > balanced_dirty_ratelimit
> @@ -941,7 +941,7 @@ static void bdi_update_dirty_ratelimit(struct backing_dev_info *bdi,
>  	 * feel and care are stable dirty rate and small position error.
>  	 *
>  	 * |task_ratelimit - dirty_ratelimit| is used to limit the step size
> -	 * and filter out the sigular points of balanced_dirty_ratelimit. Which
> +	 * and filter out the singular points of balanced_dirty_ratelimit. Which
>  	 * keeps jumping around randomly and can even leap far away at times
>  	 * due to the small 200ms estimation period of dirty_rate (we want to
>  	 * keep that period small to reduce time lags).

I'll fold the above chunk into the previous patch.

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-09 11:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-09 11:45 [PATCH] mm/page-writeback.c: fix comments error in page-writeback.c Wanpeng Li
2012-06-09 11:54 ` Fengguang Wu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).