linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>,
	linux-mm@kvack.org, hannes@cmpxchg.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH] mm/buddy: cleanup on should_fail_alloc_page
Date: Mon, 11 Jun 2012 12:40:56 +0900	[thread overview]
Message-ID: <20120611034056.GA27200@shangw> (raw)
In-Reply-To: <alpine.DEB.2.00.1206101349160.25986@chino.kir.corp.google.com>

>> In the core function __alloc_pages_nodemask() of buddy allocator, it's
>> possible for the memory allocation to fail. That's probablly caused
>> by error injection with expection. In that case, it depends on the
>> check of error injection covered by function should_fail(). Currently,
>> function should_fail() has "bool" for its return value, so it's reasonable
>> to change the return value of function should_fail_alloc_page() into
>> "bool" as well.
>> 
>
>I think we can remove the first three sentences of this.
>
>> The patch does cleanup on function should_fail_alloc_page() to "bool".
>> 
>> Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
>
>Acked-by: David Rientjes <rientjes@google.com>
>

Thanks, David. I'll adjust the changelog and send next version
as soon as possible :-)

Thanks,
Gavin

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2012-06-11  3:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-09 14:51 [PATCH] mm/buddy: cleanup on should_fail_alloc_page Gavin Shan
2012-06-10 20:50 ` David Rientjes
2012-06-11  3:40   ` Gavin Shan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120611034056.GA27200@shangw \
    --to=shangw@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).