From: Mel Gorman <mgorman@suse.de>
To: Jiang Liu <jiang.liu@huawei.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>, Hugh Dickins <hughd@google.com>,
Keping Chen <chenkeping@huawei.com>,
Tony Luck <tony.luck@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Xishi Qiu <qiuxishi@huawei.com>, Jiang Liu <liuj97@gmail.com>
Subject: Re: [PATCH] memory hotplug: fix invalid memory access caused by stale kswapd pointer
Date: Fri, 15 Jun 2012 15:28:20 +0100 [thread overview]
Message-ID: <20120615142820.GC20467@suse.de> (raw)
In-Reply-To: <1339645491-5656-1-git-send-email-jiang.liu@huawei.com>
On Thu, Jun 14, 2012 at 11:44:51AM +0800, Jiang Liu wrote:
> Function kswapd_stop() will be called to destroy the kswapd work thread
> when all memory of a NUMA node has been offlined. But kswapd_stop() only
> terminates the work thread without resetting NODE_DATA(nid)->kswapd to NULL.
> The stale pointer will prevent kswapd_run() from creating a new work thread
> when adding memory to the memory-less NUMA node again. Eventually the stale
> pointer may cause invalid memory access.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> Signed-off-by: Jiang Liu <liuj97@gmail.com>
>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-15 14:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 3:44 [PATCH] memory hotplug: fix invalid memory access caused by stale kswapd pointer Jiang Liu
2012-06-14 4:02 ` Kamezawa Hiroyuki
2012-06-14 5:31 ` Minchan Kim
2012-06-14 6:24 ` Jiang Liu
2012-06-14 8:49 ` [PATCH] trivial, memory hotplug: add kswapd_is_running() for better readability Jiang Liu
2012-06-14 11:48 ` Kamezawa Hiroyuki
2012-06-14 11:59 ` KOSAKI Motohiro
2012-06-14 15:04 ` Minchan Kim
2012-06-17 2:19 ` David Rientjes
2012-06-18 1:12 ` Minchan Kim
2012-06-18 8:25 ` KOSAKI Motohiro
2012-06-20 9:01 ` Jiang Liu
2012-06-14 5:41 ` [PATCH] memory hotplug: fix invalid memory access caused by stale kswapd pointer KOSAKI Motohiro
2012-06-15 14:28 ` Mel Gorman [this message]
2012-06-17 2:20 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120615142820.GC20467@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=chenkeping@huawei.com \
--cc=hughd@google.com \
--cc=jiang.liu@huawei.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=minchan@kernel.org \
--cc=qiuxishi@huawei.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).