From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] mm/buddy: get the allownodes for dump at once
Date: Mon, 18 Jun 2012 11:13:36 +0800 [thread overview]
Message-ID: <20120618031336.GA16855@shangw> (raw)
In-Reply-To: <jrm5fb$uji$1@dough.gmane.org>
>> When dumping the statistics for zones in the allowed nodes in the
>> function show_free_areas(), skip_free_areas_node() got called for
>> multiple times to figure out the same information: the allowed nodes
>> for dump. It's reasonable to get the allowed nodes at once.
>>
>
>I am not sure if cpuset_current_mems_allowed could be changed
>during show_free_areas(), also show_free_areas() is not called
>in any hot path...
>
Yeah, but I think it's reasonable to dump consistent nodes here.
If cpuset_current_mems_allowed gets changed on the fly, we won't
get consistent dump. So the code change would avoid non-consistent
case if possible.
Thanks,
Gavin
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-18 3:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 8:35 [PATCH] mm/buddy: get the allownodes for dump at once Gavin Shan
2012-06-18 2:57 ` Cong Wang
2012-06-18 3:13 ` Gavin Shan [this message]
2012-06-21 1:19 ` David Rientjes
2012-06-21 4:47 ` Gavin Shan
2012-06-21 5:13 ` David Rientjes
2012-06-21 5:16 ` Gavin Shan
2012-06-21 9:03 ` Cong Wang
2012-06-21 9:11 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618031336.GA16855@shangw \
--to=shangw@linux.vnet.ibm.com \
--cc=linux-mm@kvack.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).