From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx183.postini.com [74.125.245.183]) by kanga.kvack.org (Postfix) with SMTP id 938186B0062 for ; Mon, 18 Jun 2012 15:36:05 -0400 (EDT) Received: by pbbrp2 with SMTP id rp2so10669422pbb.14 for ; Mon, 18 Jun 2012 12:36:04 -0700 (PDT) Date: Mon, 18 Jun 2012 12:36:00 -0700 From: Tejun Heo Subject: Re: [PATCH v3] mm/memblock: fix overlapping allocation when doubling reserved array Message-ID: <20120618193600.GA30670@google.com> References: <1340044127-13864-1-git-send-email-greg.pearson@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340044127-13864-1-git-send-email-greg.pearson@hp.com> Sender: owner-linux-mm@kvack.org List-ID: To: Greg Pearson Cc: hpa@linux.intel.com, akpm@linux-foundation.org, shangw@linux.vnet.ibm.com, mingo@elte.hu, yinghai@kernel.org, benh@kernel.crashing.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Hello, Greg. Tricky one. Nice catch. > diff --git a/mm/memblock.c b/mm/memblock.c > index 952123e..3a61e74 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -184,7 +184,9 @@ static void __init_memblock memblock_remove_region(struct memblock_type *type, u > } > } > > -static int __init_memblock memblock_double_array(struct memblock_type *type) > +static int __init_memblock memblock_double_array(struct memblock_type *type, > + phys_addr_t exclude_start, > + phys_addr_t exclude_size) I find @exclude_start and size a bit misleading mostly because memblock_double_array() would then proceed to ignore the specified area. Wouldn't it be better to use names which signify that they're the reason why the array is being doubled instead? e.g. sth like @new_area_start, @new_area_size. Can you please also add /** function comment explaning the subtlety? Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org