From: Oleg Nesterov <oleg@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm@kvack.org
Subject: Re: [patch v2] mm, oom: do not schedule if current has been killed
Date: Tue, 19 Jun 2012 15:55:51 +0200 [thread overview]
Message-ID: <20120619135551.GA24542@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206181930550.13293@chino.kir.corp.google.com>
On 06/18, David Rientjes wrote:
>
> This patch only schedules away from current if it does not have a pending
> kill,
Can't really comment this patch, just one note...
> - if (killed && !test_thread_flag(TIF_MEMDIE))
> + if (killed && !fatal_signal_pending(current) &&
> + !(current->flags & PF_EXITING))
> schedule_timeout_uninterruptible(1);
Perhaps
if (killed && !(current->flags & PF_EXITING))
schedule_timeout_killable(1);
makes more sense?
If fatal_signal_pending() == T then schedule_timeout_killable()
is nop, but unline uninterruptible_ it can be SIGKILL'ed.
But if you prefer to check fatal_signal_pending() I won't argue.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-19 13:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 1:08 [patch] mm, oom: do not schedule if current has been killed David Rientjes
2012-06-19 1:57 ` Kamezawa Hiroyuki
2012-06-19 2:23 ` David Rientjes
2012-06-19 2:31 ` [patch v2] " David Rientjes
2012-06-19 2:51 ` Kamezawa Hiroyuki
2012-06-19 6:03 ` KOSAKI Motohiro
2012-06-19 6:26 ` David Rientjes
2012-06-19 17:32 ` KOSAKI Motohiro
2012-06-19 18:59 ` David Rientjes
2012-06-19 19:29 ` KOSAKI Motohiro
2012-06-19 13:55 ` Oleg Nesterov [this message]
2012-06-19 20:24 ` David Rientjes
2012-06-19 20:58 ` [patch v3] " David Rientjes
2012-06-19 21:39 ` KOSAKI Motohiro
2012-06-20 0:38 ` Kamezawa Hiroyuki
2012-06-21 1:23 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120619135551.GA24542@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).