From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>,
linux-mm@kvack.org, hannes@cmpxchg.org, minchan@kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH RESEND 1/2] mm/compaction: cleanup on compaction_deferred
Date: Thu, 21 Jun 2012 11:06:05 +0800 [thread overview]
Message-ID: <20120621030605.GA6846@shangw> (raw)
In-Reply-To: <alpine.DEB.2.00.1206201824550.3702@chino.kir.corp.google.com>
>> When CONFIG_COMPACTION is enabled, compaction_deferred() tries
>> to recalculate the deferred limit again, which isn't necessary.
>>
>> When CONFIG_COMPACTION is disabled, compaction_deferred() should
>> return "true" or "false" since it has "bool" for its return value.
>>
>> Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
>> Acked-by: Minchan Kim <minchan@kernel.org>
>> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
>Acked-by: David Rientjes <rientjes@google.com>
>
Thanks, David :-)
Thanks,
Gavin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-06-21 3:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 1:39 [PATCH RESEND 1/2] mm/compaction: cleanup on compaction_deferred Gavin Shan
2012-06-20 1:39 ` [PATCH RESEND 2/2] mm/buddy: get the allownodes for dump at once Gavin Shan
2012-06-21 1:25 ` [PATCH RESEND 1/2] mm/compaction: cleanup on compaction_deferred David Rientjes
2012-06-21 3:06 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621030605.GA6846@shangw \
--to=shangw@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).