From: Gavin Shan <shangw@linux.vnet.ibm.com>
To: David Rientjes <rientjes@google.com>
Cc: Gavin Shan <shangw@linux.vnet.ibm.com>,
linux-mm@kvack.org, minchan@kernel.org, mgorman@suse.de,
akpm@linux-foundation.org
Subject: Re: [PATCH] mm/buddy: get the allownodes for dump at once
Date: Thu, 21 Jun 2012 13:16:30 +0800 [thread overview]
Message-ID: <20120621051630.GA25652@shangw> (raw)
In-Reply-To: <alpine.DEB.2.00.1206202212290.25567@chino.kir.corp.google.com>
>
>> I'm not sure it's the possible to resolve the concerns with "static" here
>> since "allownodes" will be cleared for each call to show_free_areas().
>>
>> static nodemask_t allownodes;
>>
>
>There's nothing protecting concurrent access to it. This function
>certainly isn't in a performance sensitive path so I would be inclined to
>just leave it as is.
>
Ok. Thanks for comment, David.
Thanks,
Gavin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-21 5:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 8:35 [PATCH] mm/buddy: get the allownodes for dump at once Gavin Shan
2012-06-18 2:57 ` Cong Wang
2012-06-18 3:13 ` Gavin Shan
2012-06-21 1:19 ` David Rientjes
2012-06-21 4:47 ` Gavin Shan
2012-06-21 5:13 ` David Rientjes
2012-06-21 5:16 ` Gavin Shan [this message]
2012-06-21 9:03 ` Cong Wang
2012-06-21 9:11 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120621051630.GA25652@shangw \
--to=shangw@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).