Re: [PATCH] mm/buddy: get the allownodes for dump at once

[Gavin Shan <shangw@linux.vnet.ibm.com>]

>>
>> show_free_areas() is called by the oom killer, so we know two things: it 
>> can be called potentially very deep in the callchain and current is out of 
>> memory.  Both are killers for this patch since you're allocating 
>> nodemask_t on the stack here which could cause an overflow and because you 
>> can't easily fix that case with NODEMASK_ALLOC() since it allocates slab 
>> with GFP_KERNEL when we we're oom, which would simply suppress vital 
>> meminfo from being shown.
>>
>
>Adding a comment in the beginning of show_free_areas() would be nice,
>to tell people not to allocate more memory either on stack or in heap.
>

Thanks, Cong. I'll do it later :-)

Thanks,
Gavin

>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org.  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>