From: Ingo Molnar <mingo@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
Mel Gorman <mgorman@suse.de>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch 3.5-rc3] mm, mempolicy: fix mbind() to do synchronous migration
Date: Fri, 22 Jun 2012 09:12:43 +0200 [thread overview]
Message-ID: <20120622071243.GB22167@gmail.com> (raw)
In-Reply-To: <20120621184536.6dd97746.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 21 Jun 2012 17:46:52 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> > On Thu, Jun 21, 2012 at 4:46 PM, Andrew Morton
> > <akpm@linux-foundation.org> wrote:
> > >
> > > I can't really do anything with this patch - it's a bug
> > > added by Peter's "mm/mpol: Simplify do_mbind()" and added
> > > to linux-next via one of Ingo's trees.
> > >
> > > And I can't cleanly take the patch over as it's all bound
> > > up with the other changes for sched/numa balancing.
> >
> > I took the patch, it looked obviously correct (passing in a
> > boolean was clearly crap).
>
> Ah, OK, the bug was actually "retained" by "mm/mpol: Simplify
> do_mbind()".
>
> I do still ask what the plans are for that patchset..
Somewhat off topic, but the main sched/numa objections were over
the mbind/etc. syscalls and the extra configuration space - we
dropped those bits and just turned it all into an improved NUMA
scheduling feature, as suggested by Peter and me in the original
discussion.
There were no objections to that approach so the reworked NUMA
scheduling/balancing scheme is now in the scheduler tree
(tip:sched/core).
The mbind/etc. syscall changes and all the related cleanups,
speedups and reorganization of the MM code are still in limbo.
I dropped them with the rest of tip:sched/numa as nobody from
the MM side expressed much interest in them and I wanted to keep
things simple and not carry objected-to commits.
We can revive them if there's interest and consensus. I suspect
once we gather experience with the automatic NUMA scheduling
feature we'll see whether it's worth exposing that to user-space
as an ABI - or whether we should go back to random placement and
forget about it all.
Thanks,
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-22 7:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 1:00 [patch 3.5-rc3] mm, mempolicy: fix mbind() to do synchronous migration David Rientjes
2012-06-21 12:42 ` Mel Gorman
2012-06-21 23:46 ` Andrew Morton
2012-06-22 0:46 ` Linus Torvalds
2012-06-22 1:45 ` Andrew Morton
2012-06-22 2:22 ` Linus Torvalds
2012-06-22 3:33 ` Linus Torvalds
2012-06-22 3:59 ` Linus Torvalds
2012-06-22 7:12 ` Ingo Molnar [this message]
2012-06-22 7:41 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622071243.GB22167@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@elte.hu \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).