From: Andrew Morton <akpm@linux-foundation.org>
To: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
David Rientjes <rientjes@google.com>, Mel Gorman <mel@csn.ul.ie>,
Johannes Weiner <hannes@cmpxchg.org>,
Minchan Kim <minchan.kim@gmail.com>,
Wu Fengguang <fengguang.wu@intel.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH] mm: clear pages_scanned only if draining a pcp adds pages to the buddy allocator again
Date: Fri, 22 Jun 2012 14:39:03 -0700 [thread overview]
Message-ID: <20120622143903.ea1c6484.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAHGf_=rQ6AaZBjfvkWWKi+a5q+1R29_PGWDyD77VFisgJHPQEA@mail.gmail.com>
On Fri, 22 Jun 2012 17:10:59 -0400
KOSAKI Motohiro <kosaki.motohiro@gmail.com> wrote:
> On Fri, Jun 22, 2012 at 4:19 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Thu, 14 Jun 2012 12:16:10 -0400
> > kosaki.motohiro@gmail.com wrote:
> >
> >> commit 2ff754fa8f (mm: clear pages_scanned only if draining a pcp adds pages
> >> to the buddy allocator again) fixed one free_pcppages_bulk() misuse. But two
> >> another miuse still exist.
> >
> > This changelog is irritating. __One can understand it a bit if one
> > happens to have a git repo handy (and why do this to the reader?), but
> > the changelog for 2ff754fa8f indicates that the patch might fix a
> > livelock. __Is that true of this patch? __Who knows...
>
> The code in this simple patch speak the right usage, isn't it?
It depends who is listening.
Please, put yourself in the position of poor-scmuck@linux-distro.com
who is reading your patch and wondering whether it will fix some
customer bug report he is working on. Or wondering whether he should
backport it into his company's next kernel release. He simply won't be
able to do this with the information which was provided here. And if
we don't tell him, who will?
> And yes,
> this patch also fixes a possibility of live lock. (but i haven't seen actual
> live lock cause from this mistake)
hrm, I guess I'll put it in the 3.6 pile.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-06-22 21:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 16:16 [PATCH] mm: clear pages_scanned only if draining a pcp adds pages to the buddy allocator again kosaki.motohiro
2012-06-14 17:46 ` Rik van Riel
2012-06-15 7:19 ` Minchan Kim
2012-06-15 15:52 ` KOSAKI Motohiro
2012-06-15 23:21 ` Minchan Kim
2012-06-15 9:24 ` Mel Gorman
2012-06-15 16:19 ` Johannes Weiner
2012-06-16 6:55 ` Kamezawa Hiroyuki
2012-06-17 2:05 ` David Rientjes
2012-06-22 20:19 ` Andrew Morton
2012-06-22 21:10 ` KOSAKI Motohiro
2012-06-22 21:39 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120622143903.ea1c6484.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).