From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx197.postini.com [74.125.245.197]) by kanga.kvack.org (Postfix) with SMTP id CE0056B037F for ; Mon, 25 Jun 2012 14:06:24 -0400 (EDT) Received: by dakp5 with SMTP id p5so6969174dak.14 for ; Mon, 25 Jun 2012 11:06:24 -0700 (PDT) Date: Mon, 25 Jun 2012 11:06:19 -0700 From: Tejun Heo Subject: Re: [PATCH 06/11] memcg: kmem controller infrastructure Message-ID: <20120625180619.GD3869@google.com> References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-7-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340633728-12785-7-git-send-email-glommer@parallels.com> Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Pekka Enberg Again, nits. On Mon, Jun 25, 2012 at 06:15:23PM +0400, Glauber Costa wrote: > +#define mem_cgroup_kmem_on 1 > +bool __mem_cgroup_new_kmem_page(gfp_t gfp, void *handle, int order); > +void __mem_cgroup_commit_kmem_page(struct page *page, void *handle, int order); > +void __mem_cgroup_free_kmem_page(struct page *page, int order); > +#define is_kmem_tracked_alloc (gfp & __GFP_KMEMCG) Ugh... please do the following instead. static inline bool is_kmem_tracked_alloc(gfp_t gfp) { return gfp & __GFP_KMEMCG; } > #else > static inline void sock_update_memcg(struct sock *sk) > { > @@ -416,6 +423,43 @@ static inline void sock_update_memcg(struct sock *sk) > static inline void sock_release_memcg(struct sock *sk) > { > } > + > +#define mem_cgroup_kmem_on 0 > +#define __mem_cgroup_new_kmem_page(a, b, c) false > +#define __mem_cgroup_free_kmem_page(a,b ) > +#define __mem_cgroup_commit_kmem_page(a, b, c) > +#define is_kmem_tracked_alloc (false) I would prefer static inlines here too. It's a bit more code in the header but leads to less surprises (e.g. arg evals w/ side effects or compiler warning about unused vars) and makes it easier to avoid cosmetic errors. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org