From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx129.postini.com [74.125.245.129]) by kanga.kvack.org (Postfix) with SMTP id EF81C6B004D for ; Tue, 26 Jun 2012 14:00:41 -0400 (EDT) Date: Tue, 26 Jun 2012 11:01:42 -0700 From: Andrew Morton Subject: Re: [PATCH 06/11] memcg: kmem controller infrastructure Message-Id: <20120626110142.b7cf6d7c.akpm@linux-foundation.org> In-Reply-To: <4FE9CEBB.80108@parallels.com> References: <1340633728-12785-1-git-send-email-glommer@parallels.com> <1340633728-12785-7-git-send-email-glommer@parallels.com> <20120625161720.ae13ae90.akpm@linux-foundation.org> <4FE9CEBB.80108@parallels.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , David Rientjes , Pekka Enberg , Michal Hocko , Johannes Weiner , Christoph Lameter , devel@openvz.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Pekka Enberg On Tue, 26 Jun 2012 19:01:15 +0400 Glauber Costa wrote: > On 06/26/2012 03:17 AM, Andrew Morton wrote: > >> + memcg_uncharge_kmem(memcg, size); > >> >+ mem_cgroup_put(memcg); > >> >+} > >> >+EXPORT_SYMBOL(__mem_cgroup_free_kmem_page); > >> > #endif /* CONFIG_CGROUP_MEM_RES_CTLR_KMEM */ > >> > > >> > #if defined(CONFIG_INET) && defined(CONFIG_CGROUP_MEM_RES_CTLR_KMEM) > >> >@@ -5645,3 +5751,69 @@ static int __init enable_swap_account(char *s) > >> > __setup("swapaccount=", enable_swap_account); > >> > > >> > #endif > >> >+ > >> >+#ifdef CONFIG_CGROUP_MEM_RES_CTLR_KMEM > > gargh. CONFIG_MEMCG_KMEM, please! > > > > Here too. I like it as much as you do. > > But that is consistent with the rest of the file, and I'd rather have > it this way. There's not much point in being consistent with something which is so unpleasant. I'm on a little campaign to rename CONFIG_CGROUP_MEM_RES_CTLR to CONFIG_MEMCG, only nobody has taken my bait yet. Be first! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org